From owner-cvs-all@FreeBSD.ORG Tue Sep 19 20:00:58 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4839916A47B for ; Tue, 19 Sep 2006 20:00:58 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.239]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A4FA43D55 for ; Tue, 19 Sep 2006 20:00:56 +0000 (GMT) (envelope-from maksim.yevmenkin@gmail.com) Received: by wx-out-0506.google.com with SMTP id i27so4440783wxd for ; Tue, 19 Sep 2006 13:00:55 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=hqoMhUJBC31+1pXyW8DsgCrNgSxsfSHMdyWHtN4E6C5pytS9lsqDHG2SufY34rI0V1Bt7/fkGkaB3cxouRhwnHuA9bfJ9FXF4FxEZLCmSocCo3hbpF1AuYNx3n+YWk67zZ3pcyI1hm0jmD+pnUfy/qBUbZAJ1R1DZybeN6MMKq0= Received: by 10.70.22.10 with SMTP id 10mr15377595wxv; Tue, 19 Sep 2006 13:00:55 -0700 (PDT) Received: by 10.70.55.2 with HTTP; Tue, 19 Sep 2006 13:00:55 -0700 (PDT) Message-ID: Date: Tue, 19 Sep 2006 13:00:55 -0700 From: "Maksim Yevmenkin" To: "Ruslan Ermilov" In-Reply-To: <20060919194819.GA23360@rambler-co.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200609191303.k8JD3AHl050783@repoman.freebsd.org> <20060919190645.GA23068@rambler-co.ru> <20060919194819.GA23360@rambler-co.ru> Cc: cvs-src@freebsd.org, Marius Strobl , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/kbdmux kbdmux.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2006 20:00:58 -0000 On 9/19/06, Ruslan Ermilov wrote: > On Tue, Sep 19, 2006 at 12:36:38PM -0700, Maksim Yevmenkin wrote: > > nope, same crash. the only thing that seems to help is to reverting > > back to (int *) cast just like other keyboard drivers do. then it > > works. > > > > i'm in the process of getting amd64 snapshot iso to try it on a couple > > of boxes. if it will work then i'm going to back (int *) -> (intptr_t > > *) changes introduced in rev 1.8. > > > Why? amd64 and i386 are unaffected (both of my i386 and amd64 work > with the committed revision), and on sparc64 we need to find a proper > fix. It cannot work properly with (intptr_t *) removed as demonstrated > by the test program I sent to you. Here it's again for reference: ok, i'm officially confused now. from what i understood, i386 is not affected (intptr_t *) casing, right? (intptr_t *) casing causes problem with amd64, right? sparc64 crashes with (intptr_t *) casting (tested locally) now, what i'm suggesting is to replace (intptr_t *) casting with (int *) as it was before rev 1.8. i claim that after this change i386 will not affected. sparc64 will work and will not crash (tested locally) amd64 should work (i think), but i'm in the process of getting amd64 iso to build a test box. i tested (int *) casting on sparc64 with SETLED, SETREPEAT and it works fine. i made sure that parameters passed via ioctl() are all correct. i will do the same test on amd64 before committing. also, like i said before, all other keyboard drivers, including sunkbd(4) use (int *) cast and NOT (intptr_t *), and it seems to work just fine. while i'm interested what is going on here, i'd rather commit something that is tested and known to work then wait. it will buy some time to do the proper analysis and fix. thanks, max