Date: Tue, 10 Nov 2015 16:20:11 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Randall Stewart <rrs@netflix.com> Cc: Randall Ray Stewart <rrs@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290664 - in head: share/man/man9 sys/kern sys/sys Message-ID: <56420B2B.50301@selasky.org> In-Reply-To: <19671573-5C8C-4E33-845B-791DA966E4A9@netflix.com> References: <201511101449.tAAEnXIi065747@repo.freebsd.org> <56420634.5060704@selasky.org> <19671573-5C8C-4E33-845B-791DA966E4A9@netflix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/10/15 16:03, Randall Stewart wrote: > And I disagree here Hans > > You don’t need that and it just adds more into the > callout system that is not needed. Hi, It also makes debugging more easy, that you can see the last function call and argument. I.E. You should not have to clear the drain function pointer before calling the drain function. Something else. Maybe you should bump the FreeBSD version, because callout_stop() is a macro, and you've changed its API by adding another argument to _callout_stop_safe(), to force a recompilation of KLD's. Else garbage will be passed into "drain" ... --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56420B2B.50301>