Date: Mon, 31 Jul 2017 23:51:27 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Andriy Gapon <avg@FreeBSD.org> Cc: Ngie Cooper <ngie@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r321849 - in head/tools/tools: bootparttest zfsboottest Message-ID: <AA2D7845-5DAC-4ABE-8069-F4CEAFBB4534@gmail.com> In-Reply-To: <f27860f2-9835-8bbb-7066-d36f45917e36@FreeBSD.org> References: <201708010529.v715Ta2p047371@repo.freebsd.org> <f27860f2-9835-8bbb-7066-d36f45917e36@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_F8D108D6-504F-4974-B02F-C6F859EDE526 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jul 31, 2017, at 23:39, Andriy Gapon <avg@FreeBSD.org> wrote: >=20 > On 01/08/2017 08:29, Ngie Cooper wrote: >> Author: ngie >> Date: Tue Aug 1 05:29:36 2017 >> New Revision: 321849 >> URL: https://svnweb.freebsd.org/changeset/base/321849 >>=20 >> Log: >> Fix the return type for pager_output(..) in bootparttest and = zfsboottest >>=20 >> pager_output(..) has always returned int. For some reason (probably = the >> clang 5.0 update), this mismatch now results in an error with = CC=3Dclang. >>=20 >> MFC after: 1 week >=20 > I am not sure if this a correct fix... > Return value of pager_output() signifies whether to continue printing, = return > value of printf is a number of characters printed. You=E2=80=99re right =E2=80=94 it was wrong. Fixed in r321852. Thanks, -Ngie --Apple-Mail=_F8D108D6-504F-4974-B02F-C6F859EDE526 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZgCTvAAoJEPWDqSZpMIYVsDUP/0KWwpRIrElxGwHZfKJlWdwF kD64DnKZgz7uyWxyAJO8/FdD+SKAqyN9sVZsQPnSaP/JU2Yji6j9OMTwzmfy84Fo SayNGrIFBqn7aipeJSbgXt+0C5Q+3uA64fZ4gDCNrnHZlMbPojYziFOy5cpTsdkg mShZJihWYNrA/mS/F06h3RSmEj+ZWBigmXloRceKOiZyhM4Kw55kEMgbQp8cD8nq ZhrXyZnNurIrULOgQaS8I518xhRO5iIpVkNdOo5aGAa7WeK6qiquQbQ4/EXo/T4Y z4KI2sZx0/8TqJaHlN22eoWoIQkN5mQFjCBT9xJzB9yoZSmuxYcPjEYUwdxNmF+f R6p4RdbOFbbRO7lPVC9CoBLwShT9MaW5EMON/K0POTS2akeV/8SLFA5qp8VKjB8x WY0vok2T3WCH4mwJrdzD7+6tpgbZ+kCk4tJOnSrGvHbZqIKH3MXzDVBS4o4wAIQv 2TyXDfUNNwPC2BQL/5hzWzSsQ8UmpSnjS0blFbpe5p6nwsjkyGTiSv7bBiTiQkgn ynt/oCSbdIOd4cpJSfW6/4WMnuAFC46IAWXlJ3BcKRQZEpsCUPd6v0+xNaLG22uw wFNtk/Jpey1JEbWHUH4ZdYxZji8UmPR7Gd0Fp7EayuPNqSI8lDTUHj1f2OLt1+9J 7RH6Sx4Pxoml/YOujSWV =9USm -----END PGP SIGNATURE----- --Apple-Mail=_F8D108D6-504F-4974-B02F-C6F859EDE526--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AA2D7845-5DAC-4ABE-8069-F4CEAFBB4534>