Date: Tue, 7 Mar 2017 01:04:27 -0800 (PST) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: rgrimes@freebsd.org, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314833 - in head: bin/pkill lib/libxo/tests/encoder libexec/rtld-elf share/termcap usr.bin/chpass usr.bin/passwd usr.sbin/bsdinstall/partedit usr.sbin/mailwrapper usr.sbin/nologin Message-ID: <201703070904.v2794RLY093614@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <7544F39D-EFC9-4685-9238-67A45D7FE037@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> > > On Mar 6, 2017, at 21:50, Rodney W. Grimes <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: > > > >>> On Mar 6, 2017, at 21:10, Rodney W. Grimes <rgrimes@FreeBSD.org> wrote: > >>> > >>> Author: rgrimes > >>> Date: Tue Mar 7 05:10:38 2017 > >>> New Revision: 314833 > >>> URL: https://svnweb.freebsd.org/changeset/base/314833 > > ... > > > >>> > >>> -SYMLINKS+= ${LIBDIR}/${SHLIB_NAME} /usr/lib/libxo/encoder/test.enc > >>> +SYMLINKS+= ../../../tests/lib/libxo/${SHLIB_NAME} /usr/lib/libxo/encoder/test.enc > >> > >> This change breaks setting TESTSBASE != /usr/tests . Please fix (my employer depends on this being functional). > >> Thanks, > > > > I am just going to revert this until the issue with SYMLINKS vs RSYMLINKS and > > probably a much better fix in bsd.*.mk can be implemented. I can live with > > one last nasty wart of an absolute link in DESTDIR until then. The important > > functional ones are gone now. > > > > To fix this without changing SYMLINKS would involve adding a local install: > > target which would be more mess than having the one absolute link. > > The proposed enhancement for bsd.links.mk for RSYMLINKS can be found here: https://reviews.freebsd.org/D9919 . I dont think that is what bapt/bdrewery had in mind, I think they wanted to replicate the SYMLINK= as RSYMLINK= and use that when needed. I have thought about this and we do not ever want absolute links in the tree, so much simpler fix is to just convert SYMLINKS to call INSTALL_RSYMLINKS instead of INSTALL_SYMLINKS and bam, its all fixed and shall always be fixed, and as long as no one uses INSTALL_SYMLINKS. > Thanks, > -Ngie -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201703070904.v2794RLY093614>