From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jan 16 02:20:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id A81D6B4D for ; Wed, 16 Jan 2013 02:20:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 8A84FE65 for ; Wed, 16 Jan 2013 02:20:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r0G2K095057625 for ; Wed, 16 Jan 2013 02:20:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r0G2K088057624; Wed, 16 Jan 2013 02:20:00 GMT (envelope-from gnats) Resent-Date: Wed, 16 Jan 2013 02:20:00 GMT Resent-Message-Id: <201301160220.r0G2K088057624@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, John Marshall Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 13D10A19 for ; Wed, 16 Jan 2013 02:15:30 +0000 (UTC) (envelope-from john.marshall@riverwillow.com.au) Received: from mail1.riverwillow.net.au (mail1.riverwillow.net.au [203.58.93.36]) by mx1.freebsd.org (Postfix) with ESMTP id 4EF5BE40 for ; Wed, 16 Jan 2013 02:15:28 +0000 (UTC) Received: from mail3.riverwillow.net.au (svcs1.riverwillow.net.au [203.58.93.40]) by mail1.riverwillow.net.au (8.14.6/8.14.6) with ESMTP id r0G20Ffk058578 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 16 Jan 2013 13:00:16 +1100 (AEDT) Received: from rwsrv08.mby.riverwillow.net.au (localhost [127.0.0.1]) by mail3.riverwillow.net.au (8.14.6/8.14.6) with ESMTP id r0G20CEs056212 for ; Wed, 16 Jan 2013 13:00:12 +1100 (AEDT) Received: (from john@localhost) by rwsrv08.mby.riverwillow.net.au (8.14.6/8.14.6/Submit) id r0G20BMq056211; Wed, 16 Jan 2013 13:00:11 +1100 (AEDT) Message-Id: <201301160200.r0G20BMq056211@rwsrv08.mby.riverwillow.net.au> Date: Wed, 16 Jan 2013 13:00:11 +1100 (AEDT) From: John Marshall To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.113 Subject: ports/175340: [PATCH] net/nss-pam-ldapd Default nslcd build broken X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: John Marshall List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2013 02:20:00 -0000 >Number: 175340 >Category: ports >Synopsis: [PATCH] net/nss-pam-ldapd Default nslcd build broken >Confidential: no >Severity: serious >Priority: high >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Jan 16 02:20:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: John Marshall >Release: FreeBSD 9.1-RELEASE amd64 >Organization: Riverwillow Pty Ltd >Environment: System: FreeBSD rwsrv08.mby.riverwillow.net.au 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243728: Sat Dec 1 14:25:07 AEDT 2012 root@rwsrv08.mby.riverwillow.net.au:/usr/obj/usr/src/sys/RWSRV08 amd64 >Description: The optionsNG rewrite by the commiter in r310469 unintentionally broke the default build of the nslcd daemon. The incorrect assumption was that a NSLCD option existed. The port's maintainer has a note in the Makefile about not wanting to make NSLCD an option (yet), so the attached patch reverts to the previous code (which disables build of nslcd ONLY if WITHOUT_NSLCD is defined) rather than adding a NSLCD option to correct the introduced problem. >How-To-Repeat: Install the port and try (/usr/local/etc/rc.d/nslcd start). The rc script fails because it cannot find the daemon. >Fix: --- nss-pam-ldapd.diff begins here --- Index: net/nss-pam-ldapd/Makefile =================================================================== --- net/nss-pam-ldapd/Makefile (revision 310470) +++ net/nss-pam-ldapd/Makefile (working copy) @@ -1,7 +1,4 @@ -# Ports collection Makefile for: nss_ldapd -# Date created: 23/7/2009 -# Whom: melifaro@ipfw.ru -# +# Created by: melifaro@ipfw.ru # $FreeBSD$ # # vim: ft=pmake tw=78 fo=cq @@ -101,14 +98,14 @@ # Won't hook this in to OPTIONS until PADL ports are at least DEPRECATED. # It doesn't do the software any good to run as replacement for the PADL ports # without running the daemon. -.if ${PORT_OPTIONS:MNSLCD) +.if defined(WITHOUT_NSLCD) +CONFIGURE_ARGS+= --disable-nslcd +PLIST_SUB+= NSLCD="@comment " +.else CONFIGURE_ARGS+= --enable-nslcd PLIST_SUB+= NSLCD="" MAN5+= nslcd.conf.5 MAN8+= nslcd.8 -.else -CONFIGURE_ARGS+= --disable-nslcd -PLIST_SUB+= NSLCD="@comment " .endif # these are unconditionally installed (bug filed upstream) --- nss-pam-ldapd.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: