Date: Tue, 04 Sep 2012 18:31:06 +0200 From: Florian Smeets <flo@smeets.im> To: Alex Kozlov <ak@freebsd.org> Cc: svn-ports-head@freebsd.org, Doug Barton <dougb@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Shaun Amott <shaun@FreeBSD.org>, Chris Rees <utisoft@gmail.com> Subject: Re: svn commit: r303626 - head/www/xpi-firebug Message-ID: <50462CCA.5060306@smeets.im> In-Reply-To: <20120904161424.GA28248@ravenloft.kiev.ua> References: <201209032233.q83MXSa2053725@svn.freebsd.org> <50453146.2080707@smeets.im> <504537D2.5050608@FreeBSD.org> <50454279.4020309@smeets.im> <50457770.4060402@FreeBSD.org> <20120904041502.GA70861@ravenloft.kiev.ua> <CADLo838vy-%2BjvWD6ONN0KXOMFDBV=ZB-34k9ZJx7hiJs2kM83w@mail.gmail.com> <20120904161424.GA28248@ravenloft.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3B3D97AE413492126B37AAC3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 04.09.12 18:14, Alex Kozlov wrote: > On Tue, Sep 04, 2012 at 12:32:44PM +0100, Chris Rees wrote: >> On 4 Sep 2012 05:15, "Alex Kozlov" <ak@freebsd.org> wrote: >>> On Mon, Sep 03, 2012 at 08:37:20PM -0700, Doug Barton wrote: >>>> On 09/03/2012 16:51, Florian Smeets wrote: >>>>> So I reread the complete thread (r301039 and followups) again, the >>>>> only problem there seems to be is pchecker complaining, >>>> It's a problem for anything that uses 'while read ...' to process >>>> those files, including portmaster. >>> I think it breaks all parsers that assume that distinfo is a text fil= e >>> (have EoL on every line including last). >>> >>>> If you have the list of files with this problem and aren't intereste= d >>>> in fixing them, pass the list along and I'll do it. >>> I plan to fix all occurrences of this in ports tree once every few mo= nths, >>> but if you wish to fix it now, here is a list: >>> audio/pianobar/distinfo >>> devel/pecl-libevent/distinfo >>> www/xpi-firebug/distinfo >>> www/xpi-showip/distinfo >>> www/trac-accountmanager/distinfo >>> mail/meta1/distinfo >>> net/istgt/distinfo >>> sysutils/fusefs-rar2fs/distinfo >> Is this a diff/patch bug? >> Perhaps it could be fixed as well... or could its behaviour be thought= of >> as correct? > I tried many times but could not find the culprit. But I also suspect p= atch. >=20 No i don't think so, it is already in the diff you download from GNATS. I suspect it is a bug in getpatch, or one of the functions it calls, in query-pr.cgi. If you look at the patch in the PR with edit-pr (vi or vim) and use :set list you will see that the newline is there. This is why I emailed Shaun, so let's wait what he has to say. BTW this does not only affect distinfo, it's always the last file of the patch, so there are a lot of patch-* files which have a missing newline at the end. Florian --------------enig3B3D97AE413492126B37AAC3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAlBGLMoACgkQapo8P8lCvwkWxACgn+kNMe8UznmfaDHCqhu1UJns shAAoKMqAz3BAq743yferzPi78nXCtpR =6Bo/ -----END PGP SIGNATURE----- --------------enig3B3D97AE413492126B37AAC3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50462CCA.5060306>