From owner-svn-src-all@FreeBSD.ORG Mon Jan 13 01:03:20 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DBCBA3B4; Mon, 13 Jan 2014 01:03:19 +0000 (UTC) Received: from mail-ig0-x22a.google.com (mail-ig0-x22a.google.com [IPv6:2607:f8b0:4001:c05::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 805FB1164; Mon, 13 Jan 2014 01:03:19 +0000 (UTC) Received: by mail-ig0-f170.google.com with SMTP id m12so3177430iga.1 for ; Sun, 12 Jan 2014 17:03:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=gSOSTt3WeE+FSwuH+GJE5CmkiXzH8Z/7juITgc8q2Rc=; b=zFpxkgGSc5IpuOg2p4+HNt3qEkln0u5mn7uAi1vHNZYarJzv/1efgkWxVaopyFY8M3 iJPLD4Dc1gqrJUYgDk5Br9YU94UQWPFuc8crL9Zna8UhhQVpt1VUPsudANN5yTjF9OBq MFrD0LULll0TPm6HN2RXMZQKxBYzKu8F66M/JweBPoZ6dBpWQ5vZqUhK3UuRtqLXirqZ aCc4dtFNL69s4t6HUZylxtINh32xKOMnfIkI8nNZ9bA34kj1wxrOTU/g1UdaBBX7eXoK 1GOrO8kHpHBc5jlVar0oRAAr7COVJSHos27oGt68qmFWPEuqZyWBan+LM/tq6d+3PsWj 1RDw== X-Received: by 10.43.158.72 with SMTP id lt8mr18632908icc.33.1389574998867; Sun, 12 Jan 2014 17:03:18 -0800 (PST) MIME-Version: 1.0 Sender: mr.kodiak@gmail.com Received: by 10.64.6.134 with HTTP; Sun, 12 Jan 2014 17:02:48 -0800 (PST) In-Reply-To: <52D313F1.9010005@freebsd.org> References: <201401121740.s0CHelGk032373@svn.freebsd.org> <52D313F1.9010005@freebsd.org> From: Bryan Venteicher Date: Sun, 12 Jan 2014 19:02:48 -0600 X-Google-Sender-Auth: k0xBZyVysuStXagQngNOb1b2uJ4 Message-ID: Subject: Re: svn commit: r260566 - head/sys/dev/virtio/scsi To: Nathan Whitehorn Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: svn-src-head@freebsd.org, Bryan Venteicher , svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jan 2014 01:03:20 -0000 On Sun, Jan 12, 2014 at 4:15 PM, Nathan Whitehorn wrote: > This looks like it is uses a two-level set of hierarchical LUNs. Does > REPORT_LUNS not work? The new extended LUN support in CAM should be able > to handle this kind of thing now without virtio knowing anything about it. > Details from the PR seem to suggest the Google Compute Engine hypervisor (I'd guess it is some QEMU fork) doesn't support REPORT_LUNS. -Nathan > > On 01/12/14 12:40, Bryan Venteicher wrote: > > Author: bryanv > > Date: Sun Jan 12 17:40:47 2014 > > New Revision: 260566 > > URL: http://svnweb.freebsd.org/changeset/base/260566 > > > > Log: > > Remove incorrect bit shift when assigning the LUN request field > > > > This caused duplicate targets appearing on Google Compute Engine > > instances. > > > > PR: kern/185626 > > Submitted by: Venkatesh Srinivas > > MFC after: 3 days > > > > Modified: > > head/sys/dev/virtio/scsi/virtio_scsi.c > > > > Modified: head/sys/dev/virtio/scsi/virtio_scsi.c > > > ============================================================================== > > --- head/sys/dev/virtio/scsi/virtio_scsi.c Sun Jan 12 15:35:03 2014 > (r260565) > > +++ head/sys/dev/virtio/scsi/virtio_scsi.c Sun Jan 12 17:40:47 2014 > (r260566) > > @@ -1539,7 +1539,7 @@ vtscsi_set_request_lun(struct ccb_hdr *c > > lun[0] = 1; > > lun[1] = ccbh->target_id; > > lun[2] = 0x40 | ((ccbh->target_lun >> 8) & 0x3F); > > - lun[3] = (ccbh->target_lun >> 8) & 0xFF; > > + lun[3] = ccbh->target_lun & 0xFF; > > } > > > > static void > >