Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 1 Nov 2007 06:19:22 +0300
From:      Andrey Chernov <ache@nagual.pp.ru>
To:        David Xu <davidxu@FreeBSD.org>
Cc:        current@FreeBSD.org
Subject:   Re: non-functional backout for review
Message-ID:  <20071101031922.GA95201@nagual.pp.ru>
In-Reply-To: <472944C9.5020304@freebsd.org>
References:  <20071101025937.GB94332@nagual.pp.ru> <472944C9.5020304@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 01, 2007 at 11:15:21AM +0800, David Xu wrote:
> Andrey Chernov wrote:
>> Some people complaints that new check in __isctype() is not human readable 
>> and requests for backout. Compiler gives almost identical code for old and 
>> new excepting non-optimized case where non-human readable one wins. I am a 
>> bit tired to change it forth and back, so ask for final consensus here.
>> Old one
>> return (_c < 0 || _c >= 128) ? 0 :
>> New one (requests for backout)
>> return (_c & ~0x7F) ? 0 :
> 
> I will use a version which compiler can generate optimized code.
> the name __isctype already tells what the function is doing. :-)

Already done.

-- 
http://ache.pp.ru/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071101031922.GA95201>