From owner-svn-src-all@freebsd.org  Wed Oct 26 15:19:20 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1180EC22B9F;
 Wed, 26 Oct 2016 15:19:20 +0000 (UTC) (envelope-from jch@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D7D0140E;
 Wed, 26 Oct 2016 15:19:19 +0000 (UTC) (envelope-from jch@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u9QFJJaL082524;
 Wed, 26 Oct 2016 15:19:19 GMT (envelope-from jch@FreeBSD.org)
Received: (from jch@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id u9QFJJ9G082523;
 Wed, 26 Oct 2016 15:19:19 GMT (envelope-from jch@FreeBSD.org)
Message-Id: <201610261519.u9QFJJ9G082523@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: jch set sender to jch@FreeBSD.org
 using -f
From: Julien Charbon <jch@FreeBSD.org>
Date: Wed, 26 Oct 2016 15:19:19 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r307966 - head/sys/netinet
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Oct 2016 15:19:20 -0000

Author: jch
Date: Wed Oct 26 15:19:18 2016
New Revision: 307966
URL: https://svnweb.freebsd.org/changeset/base/307966

Log:
  Remove an extraneous call to soisconnected() in syncache_socket(),
  introduced with r261242.  The useful and expected soisconnected()
  call is done in tcp_do_segment().
  
  Has been found as part of unrelated PR:212920 investigation.
  
  Improve slightly (~2%) the maximum number of TCP accept per second.
  
  Tested by:		kevin.bowling_kev009.com, jch
  Approved by:		gnn, hiren
  MFC after:		1 week
  Sponsored by:		Verisign, Inc
  Differential Revision:	https://reviews.freebsd.org/D8072

Modified:
  head/sys/netinet/tcp_syncache.c

Modified: head/sys/netinet/tcp_syncache.c
==============================================================================
--- head/sys/netinet/tcp_syncache.c	Wed Oct 26 15:18:08 2016	(r307965)
+++ head/sys/netinet/tcp_syncache.c	Wed Oct 26 15:19:18 2016	(r307966)
@@ -918,10 +918,6 @@ syncache_socket(struct syncache *sc, str
 	tp->t_keepcnt = sototcpcb(lso)->t_keepcnt;
 	tcp_timer_activate(tp, TT_KEEP, TP_KEEPINIT(tp));
 
-	if ((so->so_options & SO_ACCEPTFILTER) == 0) {
-		soisconnected(so);
-	}
-
 	TCPSTAT_INC(tcps_accepts);
 	return (so);