From owner-cvs-all@FreeBSD.ORG Wed Jul 20 08:25:43 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C4C7D16A41F; Wed, 20 Jul 2005 08:25:43 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E74443D48; Wed, 20 Jul 2005 08:25:43 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id j6K8PU1e042904; Wed, 20 Jul 2005 01:25:34 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <200507200825.j6K8PU1e042904@gw.catspoiler.org> Date: Wed, 20 Jul 2005 01:25:30 -0700 (PDT) From: Don Lewis To: rwatson@FreeBSD.org In-Reply-To: <20050720091329.N50372@fledge.watson.org> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Cc: src-committers@FreeBSD.org, pjd@FreeBSD.org, cvs-src@FreeBSD.org, alfred@FreeBSD.org, cvs-all@FreeBSD.org, ps@FreeBSD.org Subject: Re: cvs commit: src/sys/nfsclient nfs_socket.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2005 08:25:44 -0000 On 20 Jul, Robert Watson wrote: > > On Tue, 19 Jul 2005, Alfred Perlstein wrote: > >>> I saw ESTALE errors on NFS clients after rebooting NFS server. >>> umount/mount was the only way to fix it. Your commit should fix my >>> problem? My machines are running 5-STABLE. >> >> Unlikely, the source of such a problem is probably that the order of >> mounted filesystems has changed and a different fsid was given to your >> exported fs. >> >> One way to fix it is to make sure that your fses are mounted in the >> right order each time. Or you can do a hack whereby exporting loads the >> fsid from a persistent file in the filesystem. > > I've been wondering for a while about the best way to address this, and a > possible start is to, on mount, attempt to derive the fsid from the uuid > of the file system (if present). We would need to then detect collisions > at run-time and fall back to an alternative fsid. The chances of a > collision are fairly low, so it might be an improvement over current > behavior. Why not specify the fsid as an option in /etc/exports?