From owner-cvs-all@FreeBSD.ORG Fri May 4 18:40:45 2012 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 379441065675 for ; Fri, 4 May 2012 18:40:45 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-pz0-f48.google.com (mail-pz0-f48.google.com [209.85.210.48]) by mx1.freebsd.org (Postfix) with ESMTP id EE6238FC0A for ; Fri, 4 May 2012 18:40:44 +0000 (UTC) Received: by dadz8 with SMTP id z8so295298dad.7 for ; Fri, 04 May 2012 11:40:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-operating-system :organization:x-living-the-dream:x-pgp-fingerprint:x-pgp-key :user-agent:x-gm-message-state; bh=YZ3+V1z4YHrGoGPVPEjZk6/62hgYPghKkj6FBK42ECc=; b=Y9IlNinKY/N4SI8fgaSqJc97au7PFU4zvS948c7qOaHglYUL55EKRcCIXWtE7CY2f7 mt8xvogcZ8CWbaZwa3N2lHcWkIYzSdwk8XdAmRXf8xCVU00QIqzj0d42FsEG08heZOYv yGyrZrCicyqxvpDVcJe9+2Ui7n4prkyB9m1Xvdjpqz88LD6AvHjNf4LWobKcXWnt1djN u0AXOV7ZTetzA1i/L2jzouPHTBCFlw7/UnsvKLlvgs9lk2LCsUiKl3ENevHOOgLB7YIB mqhH0RMN3CcszWiLTcH/xVM9KEkRzjiIahbc3OSA8bcwApvAxG9tk80FozT+KXO+LmIO C3xw== Received: by 10.68.224.165 with SMTP id rd5mr2534232pbc.60.1336156844530; Fri, 04 May 2012 11:40:44 -0700 (PDT) Received: from dormouse.experts-exchange.com ([72.29.164.238]) by mx.google.com with ESMTPS id u5sm9324626pbu.76.2012.05.04.11.40.43 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 04 May 2012 11:40:43 -0700 (PDT) Sender: Jason Helfman Date: Fri, 4 May 2012 11:39:33 -0700 From: Jason Helfman To: Michael Scheidell Message-ID: <20120504183933.GE4992@dormouse.experts-exchange.com> References: <201205041826.q44IQDl7009239@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <201205041826.q44IQDl7009239@repoman.freebsd.org> X-Operating-System: FreeBSD 8.3-RELEASE amd64 Organization: The FreeBSD Project, http://www.freebsd.org X-Living-The-Dream: I love the SLO Life! X-PGP-FingerPrint: 8E0D C457 9A0F C91C 23F3 0454 2059 9A63 4150 D3DC X-PGP-Key: http://people.freebsd.org/~jgh/jgh.asc User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQkmTAQrsDQQcFu/kDsqmnuRL+GYkFSERBSF25ngy88ejhCLuE6imQuCVN202eiLlM+t9lbo Cc: crees@freebsd.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/audio/teamspeak3-server Makefile distinfo pkg-plist ports/audio/teamspeak3-server/files pkg-message.in teamspeak.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2012 18:40:45 -0000 On Fri, May 04, 2012 at 06:26:13PM +0000, Michael Scheidell thus spake: >scheidell 2012-05-04 18:26:13 UTC > > FreeBSD ports repository > > Modified files: > audio/teamspeak3-server Makefile distinfo pkg-plist > audio/teamspeak3-server/files pkg-message.in teamspeak.in > Log: > - Update to 3.0.3 [1] > - Update LICENSE_PERMS [1] > - Add @exec's to pkg-plist since Makefile:post-install isn't run with pkg-add [2] > - Add BATCH check because you can't acctept license in batch mode [3] > - Change mkdir/chown in Makefile (and pkg-plist) to install [3] > > PR: ports/166654 [1] http://www.FreeBSD.org/cgi/query-pr.cgi?pr=166654 > Submitted by: Richard Hirner (maintainer) [1] > Submitted by: scheidell (me) [2] > Submitted by: crees@ [3] > > Revision Changes Path > 1.22 +18 -8 ports/audio/teamspeak3-server/Makefile > 1.13 +4 -4 ports/audio/teamspeak3-server/distinfo > 1.4 +1 -1 ports/audio/teamspeak3-server/files/pkg-message.in > 1.3 +4 -4 ports/audio/teamspeak3-server/files/teamspeak.in > 1.10 +11 -3 ports/audio/teamspeak3-server/pkg-plist > >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/teamspeak3-server/Makefile.diff?&r1=1.21&r2=1.22&f=h >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/teamspeak3-server/distinfo.diff?&r1=1.12&r2=1.13&f=h >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/teamspeak3-server/files/pkg-message.in.diff?&r1=1.3&r2=1.4&f=h >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/teamspeak3-server/files/teamspeak.in.diff?&r1=1.2&r2=1.3&f=h >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/teamspeak3-server/pkg-plist.diff?&r1=1.9&r2=1.10&f=h > post-install is run with pkg-add, but it depends how it is used in the port. It could be done through Makefile/pkg-install script, or in the pkg-plist. Regardless, the user and group framework already takes care of adding users/groups in packaging and through ports, so the lines adding the users/groups to the packaging list and Makefile aren't necessary. Beyond this, the USERS and GROUPS aren't needed in the PLIST_SUB. If testing this showed otherwise, I would like to see it, as I have not seen any recent breakage of this kind. Either way, thanks for your time, and the update, eventhough I don't use it. :) -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh