From owner-svn-src-all@freebsd.org  Tue Aug  1 07:14:04 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CE60ADBDB7B;
 Tue,  1 Aug 2017 07:14:04 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 87BFF67E47;
 Tue,  1 Aug 2017 07:14:03 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id KAA17592;
 Tue, 01 Aug 2017 10:14:01 +0300 (EEST)
 (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1dcRNR-000Ojb-Eh; Tue, 01 Aug 2017 10:14:01 +0300
Subject: Re: svn commit: r321849 - in head/tools/tools: bootparttest
 zfsboottest
To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
Cc: Ngie Cooper <ngie@FreeBSD.org>, src-committers@FreeBSD.org,
 svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org
References: <201708010529.v715Ta2p047371@repo.freebsd.org>
 <f27860f2-9835-8bbb-7066-d36f45917e36@FreeBSD.org>
 <AA2D7845-5DAC-4ABE-8069-F4CEAFBB4534@gmail.com>
From: Andriy Gapon <avg@FreeBSD.org>
Message-ID: <96cee950-35c2-3971-defa-be4b5493cfd3@FreeBSD.org>
Date: Tue, 1 Aug 2017 10:13:25 +0300
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <AA2D7845-5DAC-4ABE-8069-F4CEAFBB4534@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Aug 2017 07:14:04 -0000

On 01/08/2017 09:51, Ngie Cooper (yaneurabeya) wrote:
> 
>> On Jul 31, 2017, at 23:39, Andriy Gapon <avg@FreeBSD.org> wrote:
>>
>> On 01/08/2017 08:29, Ngie Cooper wrote:
>>> Author: ngie
>>> Date: Tue Aug  1 05:29:36 2017
>>> New Revision: 321849
>>> URL: https://svnweb.freebsd.org/changeset/base/321849
>>>
>>> Log:
>>>  Fix the return type for pager_output(..) in bootparttest and zfsboottest
>>>
>>>  pager_output(..) has always returned int. For some reason (probably the
>>>  clang 5.0 update), this mismatch now results in an error with CC=clang.
>>>
>>>  MFC after:	1 week
>>
>> I am not sure if this a correct fix...
>> Return value of pager_output() signifies whether to continue printing, return
>> value of printf is a number of characters printed.
> 
> You’re right — it was wrong. Fixed in r321852.

Thank you!
The next problem you are going to encounter would be missing ldi_get_size().
I have some WIP for that if you are interested.


-- 
Andriy Gapon