From owner-freebsd-ports-bugs@freebsd.org Wed Dec 30 20:08:10 2015 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EB64BA55B60 for ; Wed, 30 Dec 2015 20:08:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D6E30153D for ; Wed, 30 Dec 2015 20:08:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tBUK8AtX035945 for ; Wed, 30 Dec 2015 20:08:10 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 199480] [patch] lang/lua52, lang/lua53: use 'arc4random()' instead of 'time()' for string hash seed Date: Wed, 30 Dec 2015 20:08:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: vmagerya@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Dec 2015 20:08:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D199480 Vitaly Magerya changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155642|0 |1 is obsolete| | --- Comment #5 from Vitaly Magerya --- Created attachment 164875 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D164875&action= =3Dedit lua-arc4random.diff The update is that the upstream doesn't mind [1]. Also, based on their suggestions, here's a new (less intrusive) patch. Note that the new patch fixes what seems to be a mistake in lang/lua53/files/patch-src__Makefile: currently that file changes "CFLAGS=3D ..." into "CFLAGS?=3D ...", which makes it so that the "..." part is ignored, and the "MYCFLAGS" variable defined from lang/lua53/Makefile is never used. Note that the equivalent patch for lua52 (lang/lua53/files/patch-src__Makefile) does not add the "?", which is the correct way to do things. [1] http://article.gmane.org/gmane.comp.lang.lua.general/120118 --=20 You are receiving this mail because: You are the assignee for the bug.=