Date: Sat, 29 Jan 2005 23:39:34 +0800 From: Xin LI <delphij@frontfree.net> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: current@freebsd.org Subject: Re: We have a lot of duplicated code in the kernel Message-ID: <20050129153934.GA5834@frontfree.net> In-Reply-To: <46996.1107012088@critter.freebsd.dk> References: <20050129161022.0de822fe@Magellan.Leidinger.net> <46996.1107012088@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
--IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 29, 2005 at 04:21:28PM +0100, Poul-Henning Kamp wrote: > In message <20050129161022.0de822fe@Magellan.Leidinger.net>, Alexander Le= idinger writes: > >Hi, > > > >http://www.leidinger.net/FreeBSD/simian-20-sys-20050129.log (253k) > >contains a log of duplicated code in /sys (-current as of today). The > >file starts with files with 20 consecutive lines of duplicated code and > >ends with two files which share 1108 lines of code. > > > >If I let the program detect 6 consecutive lines of duplicated code, it > >is also able to detect possible code reuse in the same file, but it also > >prints a lot of "noise" then. > > > >I've filtered the list for some false positives (twa_fwimg, trlld?m, > >if_patm_rtables), if someone else notices some more files please tell me > >about them and I add them to the filter. >=20 > And we'll soon see the tool which generates this in src/tools/tools > somewhere I hope ? :-) A google search indicates that simian is a tool to look for similary of cod= e. http://www.redhillconsulting.com.au/products/simian/ Cheers, --=20 Xin LI <delphij frontfree net> http://www.delphij.net/ See complete headers for GPG key and other information. --IS0zKkzwUGydFO0o Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFB+642/cVsHxFZiIoRAsp5AJ9397f3YVLjv1iOREm3hRkHlXBBOgCeP8p2 CBAi7QnZg8sa53XtV578p1s= =Duiv -----END PGP SIGNATURE----- --IS0zKkzwUGydFO0o--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050129153934.GA5834>