Date: Sat, 10 Jan 2009 12:18:39 +0900 From: Pyun YongHyeon <pyunyh@gmail.com> To: Kim Culhan <w8hdkim@gmail.com> Cc: freebsd-current@freebsd.org Subject: Re: msk Marvell Yukon 88E8038 hangs Message-ID: <20090110031839.GK30747@cdnetworks.co.kr> In-Reply-To: <89dbfdc30901091243w1d01ab59mc2ade81e65e51c5d@mail.gmail.com> References: <89dbfdc30901071438j314ac431h491f9494593caf64@mail.gmail.com> <20090108011220.GA1256@cdnetworks.co.kr> <89dbfdc30901072336l62c46214i113cccf9985bcdae@mail.gmail.com> <20090108075159.GH1256@cdnetworks.co.kr> <89dbfdc30901080835g67b996f4i50e734f0791a0d56@mail.gmail.com> <20090109061032.GF30747@cdnetworks.co.kr> <89dbfdc30901091243w1d01ab59mc2ade81e65e51c5d@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--YiEDa0DAkWCtVeE4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Fri, Jan 09, 2009 at 03:43:38PM -0500, Kim Culhan wrote:
> On Fri, Jan 9, 2009 at 1:10 AM, Pyun YongHyeon <pyunyh@gmail.com> wrote:
> > On Thu, Jan 08, 2009 at 11:35:28AM -0500, Kim Culhan wrote:
> > > On Thu, Jan 8, 2009 at 2:51 AM, Pyun YongHyeon <pyunyh@gmail.com> wrote:
> > > > On Thu, Jan 08, 2009 at 02:36:48AM -0500, Kim Culhan wrote:
> > > > > On Wed, Jan 7, 2009 at 8:12 PM, Pyun YongHyeon <pyunyh@gmail.com> wrote:
> > > > > > On Wed, Jan 07, 2009 at 05:38:28PM -0500, Kim Culhan wrote:
> > > > > > > The msk interface on an Acer Aspire 5570Z hangs, frequently when running cvsup.
> > > > > > >
> > > > > > > Not necessarily at each hang but sometimes coincident, this is
> > > > > > > intermittently output to the console:
> > > > > > >
> > > > > > > in_cksum_skip: out of data by 56952
> > > > > > >
> > > > > > > The above is also output to the console at times when receiving a
> > > > > > > character through ssh
> > > > > > > to a shell.
> > > > > > >
> > > > > > > The in_cksum_skip messages and msk hangs are also present on this hardware
> > > > > > > running 7.1-RELEASE.
>
> [deleted]
>
> > Ok, then how about disabling TSO/Tx checksum offload?
> > (eg. ifconfig msk0 -tso -txcsum)
>
> This stops the messages: in_cksum_skip: out of data by 56952
Ok, would you try attached patch?
--
Regards,
Pyun YongHyeon
--YiEDa0DAkWCtVeE4
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="msk.csum.diff"
Index: sys/dev/msk/if_msk.c
===================================================================
--- sys/dev/msk/if_msk.c (revision 186998)
+++ sys/dev/msk/if_msk.c (working copy)
@@ -2608,17 +2608,14 @@
*/
if (m->m_pkthdr.len < MSK_MIN_FRAMELEN &&
(m->m_pkthdr.csum_flags & CSUM_TCP) != 0) {
- uint16_t csum;
-
m = m_pullup(m, offset + sizeof(struct tcphdr));
if (m == NULL) {
*m_head = NULL;
return (ENOBUFS);
}
- csum = in_cksum_skip(m, ntohs(ip->ip_len) + offset -
- (ip->ip_hl << 2), offset);
*(uint16_t *)(m->m_data + offset +
- m->m_pkthdr.csum_data) = csum;
+ m->m_pkthdr.csum_data) = in_cksum_skip(m,
+ m->m_pkthdr.len, offset);
m->m_pkthdr.csum_flags &= ~CSUM_TCP;
}
if ((m->m_pkthdr.csum_flags & CSUM_TSO) != 0) {
--YiEDa0DAkWCtVeE4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090110031839.GK30747>