Date: Sat, 7 Aug 2010 23:41:46 +0000 (UTC) From: Pyun YongHyeon <yongari@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r211048 - head/sys/dev/alc Message-ID: <201008072341.o77NfkEQ091884@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: yongari Date: Sat Aug 7 23:41:46 2010 New Revision: 211048 URL: http://svn.freebsd.org/changeset/base/211048 Log: Do not touch CMB TX threshold register when CMB is not used. Note, alc(4) does not use CMB at all due to silicon bug. Modified: head/sys/dev/alc/if_alc.c Modified: head/sys/dev/alc/if_alc.c ============================================================================== --- head/sys/dev/alc/if_alc.c Sat Aug 7 23:33:06 2010 (r211047) +++ head/sys/dev/alc/if_alc.c Sat Aug 7 23:41:46 2010 (r211048) @@ -2990,10 +2990,10 @@ alc_init_locked(struct alc_softc *sc) */ CSR_WRITE_4(sc, ALC_INTR_RETRIG_TIMER, ALC_USECS(0)); /* Configure CMB. */ - CSR_WRITE_4(sc, ALC_CMB_TD_THRESH, 4); - if ((sc->alc_flags & ALC_FLAG_CMB_BUG) == 0) + if ((sc->alc_flags & ALC_FLAG_CMB_BUG) == 0) { + CSR_WRITE_4(sc, ALC_CMB_TD_THRESH, 4); CSR_WRITE_4(sc, ALC_CMB_TX_TIMER, ALC_USECS(5000)); - else + } else CSR_WRITE_4(sc, ALC_CMB_TX_TIMER, ALC_USECS(0)); /* * Hardware can be configured to issue SMB interrupt based
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201008072341.o77NfkEQ091884>