Date: Tue, 07 Jul 2015 11:09:32 +0100 From: Vsevolod Stakhov <vsevolod@FreeBSD.org> To: marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r391493 - head/cad/tkgate Message-ID: <559BA55C.2080701@FreeBSD.org> In-Reply-To: <559BA1B2.4050002@marino.st> References: <201507070635.t676Zaqw085725@repo.freebsd.org> <559B9C36.2060300@FreeBSD.org> <559BA1B2.4050002@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 07/07/2015 10:53, John Marino wrote: > On 7/7/2015 11:30 AM, Vsevolod Stakhov wrote: >> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 >> >> On 07/07/2015 07:35, John Marino wrote: >>> Author: marino Date: Tue Jul 7 06:35:35 2015 New Revision: >>> 391493 URL: https://svnweb.freebsd.org/changeset/ports/391493 >>> >>> Log: cad/tkgate: Unbreak FreeBSD 11, Fix depends on rest >>> >>> This was specified on USES: iconv:build,lib >>> >>> This is incorrect; the way iconv.mk is written, "build" and >>> "lib" are mutually exclusive and "build" takes precedence. >>> This means the library dependency was not registered. >>> >>> Moveover, it's failing on FreeBSD 11 and dev-branch of >>> DragonFly because it uses transliteration. Setting >>> USES=iconv:translit fixes both issues. >>> >>> Approved by: Just fix it >> >> Well, from your commit message I can conclude merely that >> iconv.mk is broken by design. > > > It is what it is. Just look at Mk/Uses/iconv.mk By definition, > LIB_DEPENDS pulls in the port for building. This is true for all > ports. I've checked iconv.mk and that's why I'm writing this message. It is broken by definition. It doesn't follow the sane semantics of options (obviously, `build` and `lib` are *NOT* mutually exclusive as they are currently). >> Secondly, I don't understand the meaning of 'translit' option - >> it is damn confusing name and I cannot see clearly what does it >> mean in the context of dependencies. > > It means the libc iconv isn't good enough and you need the ports > libiconv. Ok, so it's the new definition of 'translit' term isn't it? No it is not! The proper name for this option should be something like 'port' and not 'translit'. >> Thirdly, isn't it a polite policy to send a notice to a >> maintainer *before* committing some change to port? > > If the port is broken, it's broken. "Just fix it" means if somebody > knows how to fix breakage shown on portsmon, we can do. (You're > welcome; I did send a courtesy message seconds after this commit) It seems that you don't understand the word 'polite' as well. >> I'm not arguing about the change itself, but I do not understand >> this 'Just fix it policy' when it's absolutely unclear, well at >> least for me, whether there's a problem with iconv.mk or with the >> port definition. > > Weren't you getting pkg-fallout messages for FreeBSD 11? The > problem is with the port. iconv changed on FreeBSD 11. I got messages from pkg-fallout but was too busy to figure out the problem. And the problem seems to be in iconv.mk from my point of view. > P.S. You revived this port incorrectly; all the history was lost. > Next time please follow this procedure: > https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ ports.html#ports-qa-re-adding > > Correct, I haven't mention that it was in the ports tree unless I'd commited it. Anyway, I can see the whole history in git: https://github.com/freebsd/freebsd-ports/commits/master/cad/tkgate/ - -- Vsevolod Stakhov -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJVm6VcAAoJEAdke2eQCBQ38j8QAKmEBnYxNr+x4bregnTRC327 pYqMWdW+eCYFgj9NjRatAvwVus5Oi2kxCHhF4EVMQ5d1aMjSeQ+GcounGrg9ld0o CAC7wEJnu51k1YnnmQdmxV98hlsMc54CZNpVBPyhalH2RSyiKcjW70SeDl7GztWR UJKi+W5EhTh867x6arLLi6XpRyaKAWLFwOzan1ToMulUhlHClA4FHIcXuM9ERqB7 ae5mouQUfvkDhNzKiG/uCMlL0e1nN/sPWo55pkJJWHRTTGsUyoYus0zfonr0N2Xx N8NwACvx5MluWoe6UhRBO1jlZS6aEb4MJ4xcH2zzEuXTnV/zwuFE8GRgrBZ/Ma0n X6l1iNLTr/dZ5RuBxSu9Qk/P5hnc1NGYTZOEWFPmq3RUlPs0B9Io7P0Gm6LimaWW 4AdXu6t+ghP8538Mw/aUGKHEJwORnm6+CPtOOtZAI3aviTTsg1TapEwr3n5SzIUy epSNuIn2xWlbk3+rV3Z5qaBet1wYdr85b+bjLcwBD8gUZMGFfWtH9o3oiBa0BNz8 Uad2HULhrLCO9jMnOR6nA1TMl+P/d5yvBhfdGOGGvR4qhdsFjNwBHM4UQ2G4qryG YGTqLzgHX7Mmpfi8RRd1VqqoS4ZyS8KtBGenl29vmBsCoWrucjbxOx63vvqCTSDJ 3w9e6Mwyx1x7PWBR40TI =mR2q -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?559BA55C.2080701>