Date: Tue, 15 Jun 2004 14:00:35 -0700 From: Peter Wemm <peter@wemm.org> To: Gordon Tetlow <gordon@FreeBSD.org> Cc: Joseph Dunn <joseph@magnesium.net> Subject: Re: cvs commit: src/sys/dev/sound/pci emu10k1.c Message-ID: <200406151400.35010.peter@wemm.org> In-Reply-To: <20040615160107.GT10016@spiff.melthusia.org> References: <200406132212.i5DMC3b9075832@repoman.freebsd.org> <40CCFCDF.4040303@freebsd.org> <20040615160107.GT10016@spiff.melthusia.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 15 June 2004 09:01 am, Gordon Tetlow wrote: > On Sun, Jun 13, 2004 at 07:18:23PM -0600, Scott Long wrote: > > >Possibly. Still doesn't mean we shouldn't add the PCI ID to help > > > people farther along in determining if it really works or not. > > > If we get reliable failure reports in 5-CURRENT (which has a much > > > updated driver from 5.2.1) we can print out an error message in > > > the probe. > > > > Well, this is kinda like finding a new Adaptec ID and adding it to > > the ahc driver just because it's there, regardless of whether the > > driver can talk to the chip. > > I would also argue that storage subsystems and sound cards are two > very different class of devices. We can afford to be a little > overzealous with sound hardware. If it doesn't work, it's not the end > of the world. If a storage subsystem that is probed doesn't work (or > worse, silently fails in subtle ways), that's much worse. Yes, and also the mode of failure is significant. If the probe/attach fails with messy errors, that is far preferable to the machine hanging in the driver. Do we know what happens as a result of the id's that David added? > -gordon -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406151400.35010.peter>