From owner-svn-src-all@freebsd.org  Wed Jan 15 22:38:11 2020
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 31C561FFC3B;
 Wed, 15 Jan 2020 22:38:11 +0000 (UTC)
 (envelope-from glebius@freebsd.org)
Received: from cell.glebi.us (glebi.us [162.251.186.162])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 47yj023Q4tz48D4;
 Wed, 15 Jan 2020 22:38:10 +0000 (UTC)
 (envelope-from glebius@freebsd.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id 00FMc63k094848
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Wed, 15 Jan 2020 14:38:07 -0800 (PST)
 (envelope-from glebius@freebsd.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id 00FMc5PR094847;
 Wed, 15 Jan 2020 14:38:05 -0800 (PST)
 (envelope-from glebius@freebsd.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@freebsd.org using -f
Date: Wed, 15 Jan 2020 14:38:05 -0800
From: Gleb Smirnoff <glebius@freebsd.org>
To: Jeff Roberson <jroberson@jroberson.net>
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
Subject: Re: svn commit: r356755 - in head/sys: net netinet netinet6
 netpfil/ipfw/nat64 sys
Message-ID: <20200115223805.GT39529@FreeBSD.org>
References: <202001150605.00F65Kc8011526@repo.freebsd.org>
 <alpine.BSF.2.21.9999.2001150944330.1198@desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.BSF.2.21.9999.2001150944330.1198@desktop>
User-Agent: Mutt/1.12.2 (2019-09-21)
X-Rspamd-Queue-Id: 47yj023Q4tz48D4
X-Spamd-Bar: /
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-0.39 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_SPAM_MEDIUM(0.51)[0.511,0];
 ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US];
 NEURAL_HAM_LONG(-0.90)[-0.899,0]
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jan 2020 22:38:11 -0000

On Wed, Jan 15, 2020 at 09:44:53AM -1000, Jeff Roberson wrote:
J> On Wed, 15 Jan 2020, Gleb Smirnoff wrote:
J> 
J> > Author: glebius
J> > Date: Wed Jan 15 06:05:20 2020
J> > New Revision: 356755
J> > URL: https://svnweb.freebsd.org/changeset/base/356755
J> >
J> > Log:
J> >  Introduce NET_EPOCH_CALL() macro and use it everywhere where we free
J> >  data based on the network epoch.   The macro reverses the argument
J> >  order of epoch_call(9) - first function, then its argument. NFC
J> 
J> Is there some practical impact of changing the argument order or does it 
J> just seem more natural to you?

It is just more natural. I'm suggesting to change prototype of epoch_call()
to the same order as well.

-- 
Gleb Smirnoff