Date: Sun, 20 May 2007 12:29:15 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: Dag-Erling Smorgrav <des@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 Message-ID: <20070520122915.7d3a195d@deskjail> In-Reply-To: <200705192034.l4JKYTWN048806@repoman.freebsd.org> References: <200705192034.l4JKYTWN048806@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting Dag-Erling Smorgrav <des@FreeBSD.org> (Sat, 19 May 2007 20:34:29 +0000 (UTC)): > des 2007-05-19 20:34:29 UTC > > FreeBSD src repository > > Modified files: > . Makefile.inc1 > Log: > Revision 1.576 removed too much. I didn't notice because my /usr is on > ZFS, which doesn't support flags... My suggestion was to remove the chflags and add a echo in the failure case of rm, because in the current way the flags are removed even if the user tells to not remove a file at the interactive rm prompt and the user is not told about it. In my original version there was an echo that the flags are removed unconditionally. Dag-Erling doesn't like the echo of removing flags when there are no flags, and I don't like that there's no echo when removing flags. To try to come to a consensus I suggested the above. It seems we need a 3rd opinion (provide your bikeshed color wisely please, think 10 times before you reply). Bye, Alexander. -- It is wise to keep in mind that neither success nor failure is ever final. -- Roger Babson http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070520122915.7d3a195d>