Date: Mon, 28 Apr 2014 09:12:52 -0400 From: John Baldwin <jhb@freebsd.org> To: Mark Murray <markm@freebsd.org> Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r265045 - projects/random_number_generator/sys/dev/random Message-ID: <2404556.5ed5qdM2Fl@ralph.baldwin.cx> In-Reply-To: <201404280751.s3S7p8Sg008554@svn.freebsd.org> References: <201404280751.s3S7p8Sg008554@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, April 28, 2014 07:51:08 AM Mark Murray wrote: > Author: markm > Date: Mon Apr 28 07:51:07 2014 > New Revision: 265045 > URL: http://svnweb.freebsd.org/changeset/base/265045 > > Log: > It turns out powerpc also doesn't have __uint128_t. > > Modified: > projects/random_number_generator/sys/dev/random/uint128.h > > Modified: projects/random_number_generator/sys/dev/random/uint128.h > ============================================================================ > == --- projects/random_number_generator/sys/dev/random/uint128.h Mon Apr 28 > 07:50:45 2014 (r265044) +++ > projects/random_number_generator/sys/dev/random/uint128.h Mon Apr 28 > 07:51:07 2014 (r265045) @@ -34,7 +34,7 @@ > * Everyone knows you always need the __uint128_t types! > */ > > -#if !defined(__arm__) && !defined(__mips__) && !defined(__i386__) && > !defined(__pc98__) +#if !defined(__arm__) && !defined(__mips__) && > !defined(__i386__) && !defined(__pc98__) && !defined(__powerpc__) /* We do > have an inbuilt __uint128_t type */ A better test would be to use #ifdef __SIZEOF_INT128__ instead of listing architectures. (Especially given it might be true on a given platform based on compiler options like -march.) This is what Boost uses to detect a native 128-bit integer and works with both GCC and clang. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2404556.5ed5qdM2Fl>