From owner-freebsd-mobile  Tue Mar 13  0:44:28 2001
Delivered-To: freebsd-mobile@freebsd.org
Received: from freebsd.dk (freebsd.dk [212.242.42.178])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2643E37B718; Tue, 13 Mar 2001 00:44:25 -0800 (PST)
	(envelope-from sos@freebsd.dk)
Received: (from sos@localhost)
	by freebsd.dk (8.9.3/8.9.1) id JAA80078;
	Tue, 13 Mar 2001 09:43:06 +0100 (CET)
	(envelope-from sos)
From: Soren Schmidt <sos@freebsd.dk>
Message-Id: <200103130843.JAA80078@freebsd.dk>
Subject: Re: iomega clik!
In-Reply-To: <200103130814.f2D8E2900479@harmony.village.org> from Warner Losh at "Mar 13, 2001 01:14:02 am"
To: imp@harmony.village.org (Warner Losh)
Date: Tue, 13 Mar 2001 09:43:05 +0100 (CET)
Cc: sos@FreeBSD.ORG, mobile@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Sender: owner-freebsd-mobile@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

It seems Warner Losh wrote:
> In message <200103130740.IAA63705@freebsd.dk> Soren Schmidt writes:
> : Thats why I have this in the patch:
> : 
> : @@ -423,5 +452,8 @@
> :      int8_t ccb[16] = { ATAPI_PREVENT_ALLOW, 0, 0, 0, lock,
> :                        0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 };
> :      
> : -    return atapi_queue_cmd(fdp->atp, ccb, NULL, 0, 0,30, NULL, NULL);
> : +    if (!strncmp(ATA_PARAM(fdp->atp->controller, fdp->atp->unit)->model, 
> : +                "IOMEGA Clik!", 12))
> : +       return 0;
> : +    return atapi_queue_cmd(fdp->atp, ccb, NULL, 0, 0, 30, NULL, NULL);
> :  }
> 
> That part of the patch didn't make it to me here.  Do you really want
> to do a string compare for every prevent_allow command?  I'd half way
> expected you to have some kind of quirk table incase iomega comes out
> with other, newer weirder drives :-).  But if that's how you want to
> do it, then that should work.

Since IOMEGA has decided to make crappy firmware, I guess they deserve
this :) BTW does the clik really have the transfer size limit as well ?
At any rate I dont think the strcmp matters, all the atapi-fd type devices
are painfully slow anyhow ...

Somebody should put IOMEGA out of their misery....

-Søren

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-mobile" in the body of the message