From owner-p4-projects@FreeBSD.ORG Wed Aug 13 21:55:37 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 391351065675; Wed, 13 Aug 2008 21:55:37 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E42DD106564A for ; Wed, 13 Aug 2008 21:55:36 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id D7E768FC16 for ; Wed, 13 Aug 2008 21:55:36 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m7DLta0u046521 for ; Wed, 13 Aug 2008 21:55:36 GMT (envelope-from ed@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m7DLta4D046519 for perforce@freebsd.org; Wed, 13 Aug 2008 21:55:36 GMT (envelope-from ed@FreeBSD.org) Date: Wed, 13 Aug 2008 21:55:36 GMT Message-Id: <200808132155.m7DLta4D046519@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to ed@FreeBSD.org using -f From: Ed Schouten To: Perforce Change Reviews Cc: Subject: PERFORCE change 147350 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Aug 2008 21:55:37 -0000 http://perforce.freebsd.org/chv.cgi?CH=147350 Change 147350 by ed@ed_dull on 2008/08/13 21:55:20 Remove unneeded minor2unit() and unit2minor(). We can just use dev2unit() here. Affected files ... .. //depot/projects/mpsafetty/sys/kern/tty_pty.c#6 edit Differences ... ==== //depot/projects/mpsafetty/sys/kern/tty_pty.c#6 (text+ko) ==== @@ -67,7 +67,7 @@ return (EBUSY); /* Generate device name and create PTY */ - u = minor2unit(minor(dev)); + u = dev2unit(dev); name[3] = u >> 8; name[4] = u; @@ -121,8 +121,8 @@ /* Create the controller device node */ u = (unsigned int)name[3] << 8 | name[4]; - *dev = make_dev_credf(MAKEDEV_REF, &ptydev_cdevsw, - unit2minor(u), NULL, UID_ROOT, GID_WHEEL, 0666, name); + *dev = make_dev_credf(MAKEDEV_REF, &ptydev_cdevsw, u, + NULL, UID_ROOT, GID_WHEEL, 0666, name); } static void