From owner-freebsd-hackers@FreeBSD.ORG Thu Mar 13 22:14:01 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1B195219; Thu, 13 Mar 2014 22:14:01 +0000 (UTC) Received: from mailuogwdur.emc.com (mailuogwdur.emc.com [128.221.224.79]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BB28E750; Thu, 13 Mar 2014 22:14:00 +0000 (UTC) Received: from maildlpprd51.lss.emc.com (maildlpprd51.lss.emc.com [10.106.48.155]) by mailuogwprd51.lss.emc.com (Sentrion-MTA-4.3.0/Sentrion-MTA-4.3.0) with ESMTP id s2DMDwKS000953 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 13 Mar 2014 18:13:58 -0400 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd51.lss.emc.com s2DMDwKS000953 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=isilon.com; s=jan2013; t=1394748838; bh=/4PXMrqikI5ZmWFMaxrekuj2Vbo=; h=From:To:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:Content-Transfer-Encoding:MIME-Version; b=XX01628KfycFUpjeit4R3b2llwHhaIkN/+3SgdQjZplhAWd2R7rQOndeITM6iH4Zd dLbPe6Qmu4rFitWwjN34AYXnRKxj0Os+LRo+MpJ+zi1PL2QwMXvrU0gQiqxrA+HLAv x6+Y21hRp0GsycPW28GYTxymUvey4FZY6yqnk2YQ= X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd51.lss.emc.com s2DMDwKS000953 Received: from mailusrhubprd03.lss.emc.com (mailusrhubprd03.lss.emc.com [10.253.24.21]) by maildlpprd51.lss.emc.com (RSA Interceptor); Thu, 13 Mar 2014 18:13:43 -0400 Received: from mxhub34.corp.emc.com (mxhub34.corp.emc.com [10.254.93.82]) by mailusrhubprd03.lss.emc.com (Sentrion-MTA-4.3.0/Sentrion-MTA-4.3.0) with ESMTP id s2DMDh4u029921 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 13 Mar 2014 18:13:43 -0400 Received: from MXHUB104.corp.emc.com (10.253.58.16) by mxhub34.corp.emc.com (10.254.93.82) with Microsoft SMTP Server (TLS) id 8.3.327.1; Thu, 13 Mar 2014 18:13:43 -0400 Received: from MX103CL02.corp.emc.com ([169.254.6.182]) by MXHUB104.corp.emc.com ([::1]) with mapi id 14.03.0158.001; Thu, 13 Mar 2014 18:13:42 -0400 From: "Meyer, Conrad" To: John Baldwin , "freebsd-hackers@freebsd.org" Subject: RE: [PATCH] x86/mca.c: malloc with correct pointer type Thread-Topic: [PATCH] x86/mca.c: malloc with correct pointer type Thread-Index: AQHPPtpBAbqAMKGBbkqrBlZQxqDI4ZrfkKWAgAAEQNc= Date: Thu, 13 Mar 2014 22:13:41 +0000 Message-ID: References: <1394728529-22495-1-git-send-email-conrad.meyer@isilon.com>, <201403131357.07665.jhb@freebsd.org> In-Reply-To: <201403131357.07665.jhb@freebsd.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.7.176.236] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Sentrion-Hostname: mailusrhubprd03.lss.emc.com X-RSA-Classifications: public X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Mar 2014 22:14:01 -0000 > From: John Baldwin [jhb@freebsd.org]=0A= > Sent: Thursday, March 13, 2014 10:57 AM=0A= > To: freebsd-hackers@freebsd.org=0A= > Cc: Meyer, Conrad=0A= > Subject: Re: [PATCH] x86/mca.c: malloc with correct pointer type=0A= > =0A= > > - cmc_state =3D malloc((mp_maxid + 1) * sizeof(struct cmc_state **)= ,=0A= > > - M_MCA, M_WAITOK);=0A= > > + cmc_state =3D malloc((mp_maxid + 1) * sizeof(*cmc_state), M_MCA,= =0A= > > + M_WAITOK);=0A= > > for (i =3D 0; i <=3D mp_maxid; i++)=0A= > > cmc_state[i] =3D malloc(sizeof(struct cmc_state) * mca_ba= nks,=0A= > > M_MCA, M_WAITOK | M_ZERO);=0A= > =0A= > I would rather do 'struct cmc_state *' as I think it is clearer to read, = but=0A= > the change is correct. Thanks!=0A= > =0A= > --=0A= > John Baldwin=0A= =0A= Sounds fine to me.=0A= =0A= Thanks,=0A= Conrad=