From owner-cvs-src@FreeBSD.ORG Fri Jan 14 18:53:42 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1391E16A4CF for ; Fri, 14 Jan 2005 18:53:42 +0000 (GMT) Received: from ns1.kolbu.ws (ns1.kolbu.ws [81.0.164.100]) by mx1.FreeBSD.org (Postfix) with SMTP id 0C87C43D31 for ; Fri, 14 Jan 2005 18:53:41 +0000 (GMT) (envelope-from oyvind@ns1.kolbu.ws) Received: (qmail 17349 invoked by uid 1000); 14 Jan 2005 18:53:39 -0000 Date: Fri, 14 Jan 2005 19:53:39 +0100 From: =?iso-8859-1?Q?=D8yvind?= Kolbu To: David Xu Message-ID: <20050114185339.GA13422@ns1.kolbu.ws> References: <200501120555.j0C5tq4L044187@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200501120555.j0C5tq4L044187@repoman.freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys umtx.h src/sys/kern kern_umtx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2005 18:53:42 -0000 On 12-01-2005 05:55, David Xu wrote: > davidxu 2005-01-12 05:55:52 UTC > > FreeBSD src repository > > Modified files: > sys/sys umtx.h > sys/kern kern_umtx.c > Log: > Let _umtx_op directly return error code rather than from errno because > errno can be tampered potentially by nested signal handle. > Now all error codes are returned in negative value, positive value are > reserved for future expansion. This broke the build cc -O2 -fno-strict-aliasing -pipe -march=pentium-m -DPTHREAD_KERNEL -D_THREAD_SAFE -I/usr/src-cur/lib/libthr/../libc/include -I/usr/src-cur/lib/libthr/t hread -I/usr/src-cur/lib/libthr/../../include -I/usr/src-cur/lib/libthr/../../libexec/rtld-elf -D_PTHREADS_INVARIANTS -g -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -c /usr/src-cur/lib/libthr/thread/thr_atfork.c In file included from /usr/src-cur/lib/libthr/thread/thr_private.h:72, from /usr/src-cur/lib/libthr/thread/thr_atfork.c:36: /usr/obj/usr/src-cur/i386/usr/include/sys/umtx.h: In function `umtx_wait': /usr/obj/usr/src-cur/i386/usr/include/sys/umtx.h:118: warning: passing arg 5 of `_umtx_op' discards qualifiers from pointer target type *** Error code 1 Stop in /usr/src-cur/lib/libthr. *** Error code 1 -- Øyvind Kolbu