Date: Sun, 15 Jul 2018 12:23:06 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Warner Losh <imp@bsdimp.com> Cc: Ian Lepore <ian@freebsd.org>, "K. Macy" <kmacy@freebsd.org>, Steve Kargl <sgk@troutmask.apl.washington.edu>, FreeBSD Current <freebsd-current@freebsd.org> Subject: RE: [PATCH] Recent libm additions Message-ID: <20180715192307.45EE0ED6@spqr.komquats.com>
next in thread | raw e-mail | index | archive | help
I wasn't saying Steve has a lock however in case non-committers might feel = they do, addressing all points in my reply. Not saying anyone feels this wa= y today but we should consider this in whatever we decide here (considering= all possibilities). IMO adding subject matter experts to MAINTAINERS seems= like the easiest way to document who might be the go-to person. --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert <Cy.Schubert@cschubert.com> or <cy@freebsd.org> The need of the many outweighs the greed of the few. --- -----Original Message----- From: Warner Losh Sent: 15/07/2018 12:09 To: Cy Schubert Cc: Ian Lepore; K. Macy; Steve Kargl; FreeBSD Current Subject: Re: [PATCH] Recent libm additions I'm not saying that he has a lock. I'm saying he's are domain expert and ma= ny mistakes can be avoided by talking to him. I'm saying we have history here, and that history, while poorly documented,= wasn't followed. To the extent it is poorly documented, we should fix that= . Warner On Sun, Jul 15, 2018 at 12:43 PM, Cy Schubert <Cy.Schubert@cschubert.com> w= rote: I don't think it makes sense for a non-committer to have a lock on anything= in base. However a request for review makes a lot of sense. If a non-commi= tter or former committer is the SME on a particular subject it's best that = they be consulted even if they don't request it. IMO more input is better. = Where better to document this than in MAINTAINERS. Having said all this. If a person is a former committer and it's not docume= nted, how are we to know? If people agree, should we start documenting SMEs in MAINTAINERS? --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert <Cy.Schubert@cschubert.com> or <cy@freebsd.org> The need of the many outweighs the greed of the few. --- From: Ian Lepore Sent: 15/07/2018 11:08 To: Warner Losh; K. Macy Cc: Steve Kargl; FreeBSD Current Subject: Re: [PATCH] Recent libm additions On Sun, 2018-07-15 at 11:55 -0600, Warner Losh wrote: > On Sun, Jul 15, 2018, 11:23 AM K. Macy <kmacy@freebsd.org> wrote: >=20 > >=20 > > >=20 > > >=20 > > > Well, actually, the functions in polevll.c should have been > > > copied > > > into ld80/e_powl.c, and polevall.c should never have been > > > committed. > > > Unfortunately, the code was not reviewed for correctness. > > That is not correct. Please stop repeating it. Bruce Evans and John > > Baldwin were both looped in. Neither made this observation. > >=20 > Steve is the fp guy these days. And it wasn't reviewed by him. He's > mad you > cut him out of the loop. Arguing about pedantic points of process > does no > one any good. >=20 > Warner On the other hand, what information is there for someone to know that Steve should be involved in a review? There is nothing in MAINTAINERS. The review was on phab for almost a month, and phab is supposedly the preferred way to do reviews these days. Steve is no longer a committer, but that doesn't preclude him having a phab account and participating in reviews. If he doesn't like using phab (and I can certainly understand that POV), an entry in MAINTAINERS would still be helpful, unless we have a rule that only committers can be listed in there. -- Ian _______________________________________________ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" =
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180715192307.45EE0ED6>