From owner-svn-src-head@freebsd.org Wed Jan 11 22:32:15 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4E4F8CAB8EE; Wed, 11 Jan 2017 22:32:15 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qk0-x244.google.com (mail-qk0-x244.google.com [IPv6:2607:f8b0:400d:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 09C171E0B; Wed, 11 Jan 2017 22:32:15 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-qk0-x244.google.com with SMTP id a20so282366qkc.3; Wed, 11 Jan 2017 14:32:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=iO8aak/MljmzY9Q9kk//8m856HWViNaypMWfsNBHR3E=; b=K1U+dgr6i/OohhyEOW0fRDAe3NowCuPxbdCTnIudlWztcfh/XT/sqF+XH0YVSUNatV EHsjNDbvlmeY0PYCSuqrjXqv2TWwi9M5Y9dzI4bdv+GgBPNqP+q2ORDCiI24bsCaFoKJ 36UZv4CQAFO5VMYPmyrONPkwuyAZMzWSeT+tC76S1eKLQTBUy/feJbg8tBQoqdvdOITM W8wCdkdAhQNUKDfNUZyKWh9yhMMFF1tRMsv8ZTOQtWFX7OOyj3VF1YemT9CGALMZRQlo QcujcfMj7T1FLa9kdmmc9VQuxOr6BdFwQckNElQouem2B1R8Ke9fYMqIeWl6FAJANT2/ UUsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iO8aak/MljmzY9Q9kk//8m856HWViNaypMWfsNBHR3E=; b=MWj7Ctd59g/wyEp8K6s6wVaYewu7WAb1Uyv3p0L+dzNJuclE5k+y7ZP+P9ON2FlN/x q8ykb7HD5GJ5QKWDroz8v5SDGcM/9geadEO1W9WZ4Yywx2fJOe/K9siioEPbOXX504J3 L8E+o6HIU3sb0KSIIdVnOrZ/ucnY2Bq0AHiZ9dv7b2MHCiXXPVQtUkAL3uEhpB3Rcwtv vo5NEtQ8FBepw3l3DAPxwq15YERpe7a8v1EHGdVGZEnYRrt0lsLSKYWYsn0C5Wxte+HD cQypGVTpkV7ftmZP0phjL16ZrKZAw7R+QpbdUvGX0sWeH6VtbkaMAZMbxi+hC/zUUwNY Lqvg== X-Gm-Message-State: AIkVDXLbx73N28/Or09MEsuri506+gG4u3CyZ7s3yKFZI6fB/Kq7aH8XW5hwrNn5smqZ9OiWFe5E7R552Ml93Q== X-Received: by 10.55.16.11 with SMTP id a11mr11756614qkh.3.1484173934201; Wed, 11 Jan 2017 14:32:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.83.133 with HTTP; Wed, 11 Jan 2017 14:32:13 -0800 (PST) In-Reply-To: <8EF36240-8CD0-449E-AA9C-EFFB7BF0C111@FreeBSD.org> References: <201701111847.v0BIl0Mg013954@repo.freebsd.org> <1484170956.86335.17.camel@freebsd.org> <8EF36240-8CD0-449E-AA9C-EFFB7BF0C111@FreeBSD.org> From: Ngie Cooper Date: Wed, 11 Jan 2017 14:32:13 -0800 Message-ID: Subject: Re: svn commit: r311929 - head/sys/boot/common To: Dimitry Andric Cc: Ian Lepore , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 22:32:15 -0000 On Wed, Jan 11, 2017 at 2:10 PM, Dimitry Andric wrote: ... > The line: > > extern int errno; > > expanded to: > > extern int (* __error()); > > which is a declaration of an external function pointer called __error > (albeit with an empty parameter list). Since nobody actually refers to > this symbol in libstand, there are no later complaints. > > Interestingly, reloc_elf.c does not use errno at all, so I have no idea > why the include was originally added. This is why: 95dd728f5ca86 (iedowse 2004-08-28 23:03:05 +0000 221) #else 95dd728f5ca86 (iedowse 2004-08-28 23:03:05 +0000 222) return (EOPNOTSUPP); 95dd728f5ca86 (iedowse 2004-08-28 23:03:05 +0000 223) #endif You probably just broke tinderbox on non-x86/-powerpc. Cheers, -Ngie