Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 Mar 2008 10:58:03 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Coleman Kane <cokane@cokane.org>
Cc:        freebsd-arch@freebsd.org
Subject:   Re: SMPTODO: remove timeout(9) from ffs_softdep.c
Message-ID:  <200803121058.04096.jhb@freebsd.org>
In-Reply-To: <47D7E5BF.2060102@cokane.org>
References:  <47D7C25D.5070908@cokane.org> <200803120945.29018.jhb@freebsd.org> <47D7E5BF.2060102@cokane.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 12 March 2008 10:16:31 am Coleman Kane wrote:
> I am attaching the revised patch.

Looks good.  I would perhaps not add the extra {}'s around the single-line if 
clauses as it slightly obfuscates the diff (style(9) actually suggests no 
{}'s in that case, but I think in practice our sources have a mixture of 
both).

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200803121058.04096.jhb>