Date: Thu, 24 May 2018 20:53:37 +0530 From: Pratyush Yadav <pratyush@freebsd.org> To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com> Cc: FreeBSD-Xen <freebsd-xen@freebsd.org> Subject: Re: Leftover code in gnttab.h? Message-ID: <CA%2BX=3TLFCW=CgZiujcvZHk3FMXWYdbGm12uRmTSETw%2BcEztWUw@mail.gmail.com> In-Reply-To: <20180524151201.gtpey5wifislq3z2@MBP-de-Roger.citrite.net> References: <CA%2BX=3TJ0OubDVenkjC0CQnv9Cqc64cdXzwbO=qY1ZSq3dLXG6Q@mail.gmail.com> <20180524140636.7vz2gjshqow6efwe@MBP-de-Roger.citrite.net> <CA%2BX=3TK3KzhhuV8Fte3w%2BZm44F6as3KpdvUBF%2BdeJuj9%2BS9yGA@mail.gmail.com> <20180524151201.gtpey5wifislq3z2@MBP-de-Roger.citrite.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 24, 2018 at 8:42 PM, Roger Pau Monn=C3=A9 <roger.pau@citrix.com= > wrote: > On Thu, May 24, 2018 at 08:38:30PM +0530, Pratyush Yadav wrote: >> Hi, >> >> On Thu, May 24, 2018 at 7:36 PM, Roger Pau Monn=C3=A9 <roger.pau@citrix.= com> wrote: >> > On Thu, May 24, 2018 at 05:53:02PM +0530, Pratyush Yadav wrote: >> >> Hi everyone, >> >> >> >> I was reading the Xen grant table code and I noticed that some code i= s >> >> wrapped in an #if 0. You can see it in sys/xen/gnttab.h:138. I have >> >> also attached the "commented out" part down below. >> >> >> >> Is it useful? Is it all right if I submit a patch that removes it? >> > >> > This are leftovers from when the code was imported from Linux AFAICT. >> > I guess the original committer thought that those functions would be >> > implemented, so the prototypes where left in place. >> > >> > If you give me a patch to remove them I'm happy to commit it. >> >> How should I send you the patch? Should I send it through >> reviews.freebsd.org, GitHub pull request or just paste the patch in >> the email? > > Let's use reviews.freebsd.org, so that you can get used to it. In case you didn't get the notificaton: https://reviews.freebsd.org/D15553 --=20 Regards, Pratyush Yadav
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BX=3TLFCW=CgZiujcvZHk3FMXWYdbGm12uRmTSETw%2BcEztWUw>