From owner-cvs-ports@FreeBSD.ORG Sun May 1 18:39:30 2011 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id F2DEA1065672; Sun, 1 May 2011 18:39:29 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 65-241-43-5.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id A35CF156107; Sun, 1 May 2011 18:38:39 +0000 (UTC) Message-ID: <4DBDA8AE.4030405@FreeBSD.org> Date: Sun, 01 May 2011 11:38:38 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.17) Gecko/20110429 Thunderbird/3.1.10 MIME-Version: 1.0 To: Greg Larkin References: <201104271329.p3RDTMPV048564@repoman.freebsd.org> In-Reply-To: <201104271329.p3RDTMPV048564@repoman.freebsd.org> X-Enigmail-Version: 1.1.2 OpenPGP: id=1A1ABC84 Content-Type: multipart/mixed; boundary="------------080604040106000909020506" Cc: cvs-ports@FreeBSD.org, Uffe Jakobsen , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/mail/nullmailer Makefile distinfo pkg-plist ports/mail/nullmailer/files nullmailer.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 May 2011 18:39:30 -0000 This is a multi-part message in MIME format. --------------080604040106000909020506 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Nice, thanks. :) One question, is nullmailer a daemon, or does it exit after this script is run? If it's persistent, then adding KEYWORD: shutdown is probably a good idea. The one change that is necessary is a default setting for _enable. Please review the attached patch. Doug On 04/27/2011 06:29, Greg Larkin wrote: > glarkin 2011-04-27 13:29:22 UTC > > FreeBSD ports repository > > Modified files: > mail/nullmailer Makefile distinfo pkg-plist > mail/nullmailer/files nullmailer.in > Log: > - Fixed spool file ownerships when installing from a package > - Various pkg-plist cleanups to ensure that chmod/chown commands are > executed in the proper order during package installation > - Added LICENSE > - Fixed REQUIRES: in rc.d script > - Bumped PORTREVISION > > PR: ports/154437 (based on) http://www.FreeBSD.org/cgi/query-pr.cgi?pr=154437 > Submitted by: Uffe Jakobsen > > Revision Changes Path > 1.21 +18 -7 ports/mail/nullmailer/Makefile > 1.9 +0 -1 ports/mail/nullmailer/distinfo > 1.4 +2 -2 ports/mail/nullmailer/files/nullmailer.in > 1.8 +11 -14 ports/mail/nullmailer/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/nullmailer/Makefile.diff?&r1=1.20&r2=1.21&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/nullmailer/distinfo.diff?&r1=1.8&r2=1.9&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/nullmailer/files/nullmailer.in.diff?&r1=1.3&r2=1.4&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/nullmailer/pkg-plist.diff?&r1=1.7&r2=1.8&f=h > -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ --------------080604040106000909020506 Content-Type: text/plain; name="nullmailer-rcd.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="nullmailer-rcd.diff" Index: Makefile =================================================================== RCS file: /home/pcvs/ports/mail/nullmailer/Makefile,v retrieving revision 1.21 diff -u -r1.21 Makefile --- Makefile 27 Apr 2011 13:29:21 -0000 1.21 +++ Makefile 1 May 2011 18:37:12 -0000 @@ -7,7 +7,7 @@ PORTNAME= nullmailer PORTVERSION= 1.05 -PORTREVISION= 2 +PORTREVISION= 3 PORTEPOCH= 1 CATEGORIES= mail MASTER_SITES= http://untroubled.org/nullmailer/ \ Index: files/nullmailer.in =================================================================== RCS file: /home/pcvs/ports/mail/nullmailer/files/nullmailer.in,v retrieving revision 1.4 diff -u -r1.4 nullmailer.in --- files/nullmailer.in 27 Apr 2011 13:29:21 -0000 1.4 +++ files/nullmailer.in 1 May 2011 18:37:12 -0000 @@ -1,8 +1,10 @@ #!/bin/sh + # $FreeBSD: ports/mail/nullmailer/files/nullmailer.in,v 1.4 2011/04/27 13:29:21 glarkin Exp $ # # PROVIDE: nullmailer # REQUIRE: LOGIN +# KEYWORD: shutdown # # Add the following line to /etc/rc.conf to enable nullmailer: # @@ -13,9 +15,13 @@ name=nullmailer rcvar=`set_rcvar` + command=/usr/sbin/daemon procname=%%PREFIX%%/sbin/nullmailer-send command_args=" -cf -u %%NULLMAIL_USER%% /bin/sh -c '$procname | /usr/bin/logger -i -p mail.info -t $name'" + load_rc_config $name -run_rc_command "$1" +: nullmailer_enable=${nullmailer_enable:=NO} + +run_rc_command "$1" --------------080604040106000909020506--