From owner-svn-src-all@FreeBSD.ORG  Mon Jun  8 20:24:29 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DCA0F1065672;
	Mon,  8 Jun 2009 20:24:29 +0000 (UTC) (envelope-from ed@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id CBB3B8FC18;
	Mon,  8 Jun 2009 20:24:29 +0000 (UTC) (envelope-from ed@FreeBSD.org)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n58KOTa7042430;
	Mon, 8 Jun 2009 20:24:29 GMT (envelope-from ed@svn.freebsd.org)
Received: (from ed@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id n58KOTXU042429;
	Mon, 8 Jun 2009 20:24:29 GMT (envelope-from ed@svn.freebsd.org)
Message-Id: <200906082024.n58KOTXU042429@svn.freebsd.org>
From: Ed Schouten <ed@FreeBSD.org>
Date: Mon, 8 Jun 2009 20:24:29 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r193752 - head/sys/dev/kbdmux
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jun 2009 20:24:30 -0000

Author: ed
Date: Mon Jun  8 20:24:29 2009
New Revision: 193752
URL: http://svn.freebsd.org/changeset/base/193752

Log:
  Use proper types in kbdmux_kbd_getc():
  
  - The return value should be a signed integer, because -1 means failure.
  - The c variable should be unsigned, to force it to be zero-extended
    when returned.
  
  Reported by:	Andreas Tobler <andreast-list fgznet ch>

Modified:
  head/sys/dev/kbdmux/kbdmux.c

Modified: head/sys/dev/kbdmux/kbdmux.c
==============================================================================
--- head/sys/dev/kbdmux/kbdmux.c	Mon Jun  8 20:08:20 2009	(r193751)
+++ head/sys/dev/kbdmux/kbdmux.c	Mon Jun  8 20:24:29 2009	(r193752)
@@ -181,10 +181,10 @@ kbdmux_kbd_putc(kbdmux_state_t *state, c
 	state->ks_inq_length++;
 }
 
-static char
+static int
 kbdmux_kbd_getc(kbdmux_state_t *state)
 {
-	char c;
+	unsigned char c;
 
 	if (state->ks_inq_length == 0)
 		return (-1);