Date: Fri, 27 Oct 2017 11:36:00 -0400 From: Mike Tancsa <mike@sentex.net> To: Eugene Grosbein <eugen@grosbein.net>, FreeBSD-STABLE Mailing List <freebsd-stable@freebsd.org> Subject: Re: ppp routing bug ? Message-ID: <639cc812-d865-15a7-eda1-cb71575dc2e6@sentex.net> In-Reply-To: <59F25ED0.1010001@grosbein.net> References: <bdb4d277-40ca-5a8e-f0e0-c1734a0c88c6@sentex.net> <a23ed8b3-1050-12d5-6a7c-1a1a0c174251@sentex.net> <59F1B650.5070107@grosbein.net> <22c3cbd4-2a8e-884f-ec9b-cc4d12ff818f@sentex.net> <59F1EA48.1090500@grosbein.net> <a019ac21-fd1a-6f69-257f-4c03515ec963@sentex.net> <59F206CB.5000006@grosbein.net> <98f44309-d706-4cef-c0b2-0f08e0e1855c@sentex.net> <59F25ED0.1010001@grosbein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/26/2017 6:16 PM, Eugene Grosbein wrote: > 27.10.2017 1:04, Mike Tancsa пишет: >> >> the borked route monitor looks like >> >> got message of size 124 on Thu Oct 26 12:21:12 2017 >> RTM_ADD: Add Route: len 124, pid: 29597, seq 2, errno 0, >> flags:<UP,GATEWAY,DONE,STATIC> >> locks: inits: >> sockaddrs: <DST,GATEWAY> >> 192.168.134.2 64.7.128.7 >> >> >> got message of size 196 on Thu Oct 26 12:21:13 2017 >> RTM_CHANGE: Change Metrics or flags: len 196, pid: 29597, seq 5, errno >> 0, flags:<UP,DONE,STATIC> >> locks: inits: <mtu> >> sockaddrs: <DST,GATEWAY,IFP,IFA> >> 192.168.134.2 64.7.128.7 tun0 98-159-244-185.agas1a-dynamic.dsl.sentex.ca > > That makes sense: ppp send bogus request to the routing socket and > the request has not RTF_HOST flag nor RTA_NETMASK address. > It seems, earlier kernel code masked this bug somehow but it does not now. > > Anyway, we have two bugs here: ppp sending bad request and kernel having > no enough checks for this somehow. > > Fixing ppp part would be easy. Please try this patch: Thanks, that seems to restore the earlier functionality! ---Mike -- ------------------- Mike Tancsa, tel +1 519 651 3400 Sentex Communications, mike@sentex.net Providing Internet services since 1994 www.sentex.net Cambridge, Ontario Canada http://www.tancsa.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?639cc812-d865-15a7-eda1-cb71575dc2e6>