From owner-svn-src-all@freebsd.org Wed Oct 31 14:07:17 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1137B10DA594 for ; Wed, 31 Oct 2018 14:07:17 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 89AF2768AD for ; Wed, 31 Oct 2018 14:07:16 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-ed1-x544.google.com with SMTP id w19-v6so13726076eds.1 for ; Wed, 31 Oct 2018 07:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Xda4X/sBW0jPMVbmpuTzQ0rtkGQmp96cP+tc02JwxRw=; b=XWExuOy0XJY5SsAGKAlmB0+Qu25YjYqUXX2d2Vnwn9zXS/VnbVB3gk/IG6HH2Ixmvj 3XKB50PVOil417gKuOY1n/gWfW+p4jziaxmxX9NmvsIS6FAwgn0TnGiS5jUS/YkqbsY2 OYXrb1U2QNejTcNMLwdVtnKucdqvSbhX9cbxBKlKBTghXLQeWt77m/7Wvgkd8JDWz03n BmD9kkLWz5x1Xi3HWQ18GhDXUeDzwV09f9ZLKTcWIAW3GXfFPM4iNLWKg5oYy9k07NN8 rQNaQy6yqKG5n7HPsqRxTd2S8g9v4F06s/h/A2XGOAGHajpEvO5b/oTlqaiBRyYEYc/I z+bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Xda4X/sBW0jPMVbmpuTzQ0rtkGQmp96cP+tc02JwxRw=; b=Cju0515OUUdGC8eHC6cLdanhoLTD9VfUyC8xXQNtJPXAsaM2GFq2wETXDzqLp0Nujr ja+4EnAoMJBfkeaMliiawrrwSF69lUxYHps5uPPb4RZOoqpBmmdgzMhb9JnHGCjGL+5X PF/yq6KiO+m2aUNI2lNYP5pSi6ygPjAzWX+lI9N2cHA8WqYGuiGMXNXeoCUPVZlTnqct egn6dBe+HkhTHhRS9ngJkyn9MG7c94hOhELYej4DJMGMpqSsD92dyIkZGFm7gIUFCooY 2IpklRs1rScgfBrTGGZBZCl0C6Feq3cYcsM2UEjbwW4AcKIFdSy55DDwIQSo5eqOIPVe iOsQ== X-Gm-Message-State: AGRZ1gLZfW8wf8iq4VobtbYWYtmKDJdf+9se+xFngN6N2FUzH73FFVZM HW+pf4qRDAGYByuAgTumNg/3Gw43wYcXsg== X-Google-Smtp-Source: AJdET5eRinbtdIfzqXR6QEcHkGFH3aHe/4mAxlNNEXPWVvoZplZFKZuusIMB0yAJHcL/54cFUSLJQw== X-Received: by 2002:aa7:d804:: with SMTP id v4-v6mr2203041edq.255.1540994835299; Wed, 31 Oct 2018 07:07:15 -0700 (PDT) Received: from mutt-hbsd ([5.101.40.89]) by smtp.gmail.com with ESMTPSA id b9-v6sm2742217ejd.3.2018.10.31.07.07.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Oct 2018 07:07:14 -0700 (PDT) Date: Wed, 31 Oct 2018 10:06:31 -0400 From: Shawn Webb To: Marcelo Araujo Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339936 - head/sys/amd64/vmm/amd Message-ID: <20181031140631.ipwlwh3rlm7ma4xk@mutt-hbsd> References: <201810310127.w9V1RiFX025463@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xvtltbeb4cvnrabj" Content-Disposition: inline In-Reply-To: <201810310127.w9V1RiFX025463@repo.freebsd.org> X-Operating-System: FreeBSD mutt-hbsd 12.0-ALPHA7 FreeBSD 12.0-ALPHA7 X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: NeoMutt/20180622 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Oct 2018 14:07:17 -0000 --xvtltbeb4cvnrabj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 31, 2018 at 01:27:44AM +0000, Marcelo Araujo wrote: > Author: araujo > Date: Wed Oct 31 01:27:44 2018 > New Revision: 339936 > URL: https://svnweb.freebsd.org/changeset/base/339936 >=20 > Log: > Merge cases with upper block. > This is a cosmetic change only to simplify code. > =20 > Reported by: anish > Sponsored by: iXsystems Inc. >=20 > Modified: > head/sys/amd64/vmm/amd/svm_msr.c >=20 > Modified: head/sys/amd64/vmm/amd/svm_msr.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/amd64/vmm/amd/svm_msr.c Tue Oct 30 23:09:04 2018 (r339935) > +++ head/sys/amd64/vmm/amd/svm_msr.c Wed Oct 31 01:27:44 2018 (r339936) > @@ -122,11 +122,7 @@ svm_rdmsr(struct svm_softc *sc, int vcpu, u_int num,= u > case MSR_MTRR16kBase ... MSR_MTRR16kBase + 1: > case MSR_MTRR64kBase: > case MSR_SYSCFG: > - *result =3D 0; > - break; > case MSR_AMDK8_IPM: > - *result =3D 0; > - break; > case MSR_EXTFEATURES: > *result =3D 0; > break; Does this need a /* FALLTHROUGH */ comment to appease the Coverity Gods? Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --xvtltbeb4cvnrabj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAlvZtuIACgkQaoRlj1JF bu7YFxAAotLfwS4nmHkls1xlMbHO3p+lP7fFfthSLhnsEFSHLNCxtNRcLYCFyIpU TiSKpDWZ7yAJOtW5vjEjZFSRNC5CEaXBGJN0wCHdhlsbFhtdh7RvmYazNB/U6zTC hCuCdXnRThDKhfU3Rbb8Fax+Lnp/t38tm7e/w4z7h/D/6k7Fb2MjmADVAiwi5epn RLKu4KtUl3DUr2gBhsEkedJx7peWPdALiQE2MOA//A2hOTyE9SSjcL2mvOLsdC8i iVsT2bBWhVjIamxMXXjO0v+lq6eR8WGkqwDVoHHDXJcimmqtytp7rCAm+UNiI3Jg Z53edZLY1Ghj5rptb3xg/SsGUqC2GlBz+ey12YobxcX6/yPjKvJ3xO3W1FLmM+/g A8T04chtwtJG9XNe87L45TD1GvSWNR85mRHoV4TLieajUnCA8hjzovteBbcKffnt bAAwPmJ/SNVlH4+YAGN39bjfMYwqXZ/DUatbLWaUi2uG2W+i6n/Hifjr1bu3ZvOZ c/mR7IRvvQQh4QrAZXg/uR1+dPylNwwKJGt3SaauZGK1Ph5OKs1gT0JIs5eZB90e peT+KYSthlC4CVu9KKkiKzdD+vw0y9iCgb3OnbtGlp/kQfjdU0GfJlKviiucYg/T poKWItRICo32mTUmVPPKM6+4zFeEUbLgmB+02yjosN0U7/v7Z2w= =It1J -----END PGP SIGNATURE----- --xvtltbeb4cvnrabj--