From owner-freebsd-ports-bugs Wed Feb 12 17:20:13 2003 Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10B4D37B401 for ; Wed, 12 Feb 2003 17:20:11 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id C6CD443FD7 for ; Wed, 12 Feb 2003 17:20:07 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h1D1K7NS015510 for ; Wed, 12 Feb 2003 17:20:07 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h1D1K78G015509; Wed, 12 Feb 2003 17:20:07 -0800 (PST) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 636BD37B401 for ; Wed, 12 Feb 2003 17:10:14 -0800 (PST) Received: from mail.dt.e-technik.uni-dortmund.de (krusty.dt.E-Technik.Uni-Dortmund.DE [129.217.163.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 83CA443F3F for ; Wed, 12 Feb 2003 17:10:13 -0800 (PST) (envelope-from matthias.andree@web.de) Received: from m2a2.dyndns.org (krusty.dt.e-technik.uni-dortmund.de [129.217.163.1]) by mail.dt.e-technik.uni-dortmund.de (Postfix) with ESMTP id 7D185A381D for ; Thu, 13 Feb 2003 02:10:12 +0100 (CET) Received: from libertas.emma.line.org (libertas.emma.line.org [192.168.0.2]) by merlin.emma.line.org (Postfix) with ESMTP id 9FF807886D for ; Thu, 13 Feb 2003 02:10:10 +0100 (CET) Received: from libertas.emma.line.org (localhost [127.0.0.1]) by libertas.emma.line.org (8.12.6/8.12.6) with ESMTP id h1D1AAri006125 for ; Thu, 13 Feb 2003 02:10:10 +0100 (CET) (envelope-from emma@libertas.emma.line.org) Received: (from emma@localhost) by libertas.emma.line.org (8.12.6/8.12.6/Submit) id h1D1A9w3006124; Thu, 13 Feb 2003 02:10:09 +0100 (CET) (envelope-from emma) Message-Id: <200302130110.h1D1A9w3006124@libertas.emma.line.org> Date: Thu, 13 Feb 2003 02:10:09 +0100 (CET) From: Matthias Andree Reply-To: Matthias Andree To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/48221: portlint: bogus warnings about DISTFILES Sender: owner-freebsd-ports-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 48221 >Category: ports >Synopsis: portlint: bogus warnings about DISTFILES >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Feb 12 17:20:07 PST 2003 >Closed-Date: >Last-Modified: >Originator: Matthias Andree >Release: FreeBSD 4.7-STABLE i386 >Organization: >Environment: System: FreeBSD libertas.emma.line.org 4.7-STABLE FreeBSD 4.7-STABLE #8: Fri Jan 31 03:10:11 CET 2003 toor@libertas.emma.line.org:/usr/obj/usr/src/sys/LIBERTAS i386 >Description: portlint is too picky about some constructs: The new feature of adding :CLASS style grouping to master sites and subdirs requires the use of DISTFILES with a single file -- portlint complains: WARN: use of DISTFILES with single file discouraged. distribution filename should be set by DISTNAME and EXTRACT_SUFX. Also, this warning is utterly bogus and will catch a lot of ports that use automake or similar "make dist" schemes but have a name that is inadequate for FreeBSD's port system: WARN: do not use DISTFILES and DISTNAME to control WRKSRC. how about "WRKSRC=${WRKDIR}/${PORTNAME}-${PORTVERSION}.rel"? WKRSRC is implicitly derived using DISTNAME in /usr/ports/Mk/bsd.port.mk, so this warning is bogus -- or /usr/ports/Mk/bsd.port.mk should be fixed instead. >How-To-Repeat: Check out ports/news/leafnode with -D '2003-02-13 01:00' (that's GMT), it should yield Makefile 1.28 or 1.29 (both reproduce the problem). Then run portlint in that port's directory. >Fix: >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports-bugs" in the body of the message