From owner-svn-src-head@FreeBSD.ORG Sat May 12 00:04:01 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 47FE9106566B; Sat, 12 May 2012 00:04:01 +0000 (UTC) (envelope-from delphij@gmail.com) Received: from mail-qa0-f49.google.com (mail-qa0-f49.google.com [209.85.216.49]) by mx1.freebsd.org (Postfix) with ESMTP id B27198FC08; Sat, 12 May 2012 00:04:00 +0000 (UTC) Received: by qabj40 with SMTP id j40so2266103qab.15 for ; Fri, 11 May 2012 17:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=C2UKwC0zNlAlL+rIJG9h1smL4yE8LDGKA35bQhBKRkc=; b=HlJVe81xht2F+u9p4kN02161P2KgM/Zu84ptLo5U7EfTHO2jEahU4L7DKs/s3iewX0 RFR0OS4d1wVTBFszLiOfakMBE8cCPxW9L4EojDfRcQmj6/jzXrwryLNrzkMPNBhW9JZI Nu+OM0aGxtsYdGO+88TUWQI7Z+6BAEuJcbkaL8pkPlZAClt5SMf+o+NHxr34StStz9bS a1fuXBPqxelZ566GrwLpfmIAtbYqjYhTCH++cNvYBNoymM041pOzH9ROSOfFz/Cux060 GPDnWVVUMckYnrOGZQmp619krWCEyBfuEt3tB24NBhACG9CmP89FW0NQZv5pKVMu5jIV Bk+A== MIME-Version: 1.0 Received: by 10.229.137.147 with SMTP id w19mr6481qct.132.1336781039802; Fri, 11 May 2012 17:03:59 -0700 (PDT) Received: by 10.229.81.1 with HTTP; Fri, 11 May 2012 17:03:59 -0700 (PDT) In-Reply-To: <201205112343.q4BNhWh7005829@svn.freebsd.org> References: <201205112343.q4BNhWh7005829@svn.freebsd.org> Date: Fri, 11 May 2012 17:03:59 -0700 Message-ID: From: Xin LI To: Xin LI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r235301 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 May 2012 00:04:01 -0000 On Fri, May 11, 2012 at 4:43 PM, Xin LI wrote: > Author: delphij > Date: Fri May 11 23:43:32 2012 > New Revision: 235301 > URL: http://svn.freebsd.org/changeset/base/235301 > > Log: > =C2=A0Revert previous revision, misunderstood the code :( > > Modified: > =C2=A0head/sys/kern/kern_kthread.c > > Modified: head/sys/kern/kern_kthread.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/kern_kthread.c =C2=A0 =C2=A0 =C2=A0 =C2=A0Fri May 11 23= :41:52 2012 =C2=A0 =C2=A0 =C2=A0 =C2=A0(r235300) > +++ head/sys/kern/kern_kthread.c =C2=A0 =C2=A0 =C2=A0 =C2=A0Fri May 11 23= :43:32 2012 =C2=A0 =C2=A0 =C2=A0 =C2=A0(r235301) > @@ -182,7 +182,6 @@ kproc_suspend(struct proc *p, int timo) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return (EINVAL); > =C2=A0 =C2=A0 =C2=A0 =C2=A0} > =C2=A0 =C2=A0 =C2=A0 =C2=A0SIGADDSET(p->p_siglist, SIGSTOP); > - =C2=A0 =C2=A0 =C2=A0 PROC_UNLOCK(p); > =C2=A0 =C2=A0 =C2=A0 =C2=A0wakeup(p); > =C2=A0 =C2=A0 =C2=A0 =C2=A0return msleep(&p->p_siglist, &p->p_mtx, PPAUSE= | PDROP, "suspkp", timo); For the record, p->p_mtx is the mutex used by PROC_[UN]LOCK(), which has to be held while calling msleep(). Cheers, --=20 Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die