Date: Tue, 28 Jun 2011 16:01:17 GMT From: Robert Millan <rmh@debian.org> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/158398: <geom/geom.h> includes <sys/sbuf.h> gratuitously Message-ID: <201106281601.p5SG1Hln057769@red.freebsd.org> Resent-Message-ID: <201106281610.p5SGA9NN016600@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 158398 >Category: misc >Synopsis: <geom/geom.h> includes <sys/sbuf.h> gratuitously >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jun 28 16:10:09 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Robert Millan >Release: Debian GNU/kFreeBSD "sid" >Organization: >Environment: >Description: <geom/geom.h> includes <sys/sbuf.h> but doesn't really need it, since struct sbuf s treated as an opaque struct in this file. Please consider removing this include, in Debian this makes life easier since libsbuf is a separate package and may not be available to <geom/geom.h> users. >How-To-Repeat: >Fix: Patch attached with submission follows: --- a/sys/geom/geom.h +++ b/sys/geom/geom.h @@ -43,7 +43,6 @@ #include <sys/sx.h> #include <sys/queue.h> #include <sys/ioccom.h> -#include <sys/sbuf.h> #include <sys/module.h> struct g_class; >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201106281601.p5SG1Hln057769>