From owner-svn-src-head@freebsd.org  Wed Jan 11 22:37:04 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AE0DFCABCA3;
 Wed, 11 Jan 2017 22:37:04 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (tensor.andric.com
 [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "tensor.andric.com",
 Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 72260159F;
 Wed, 11 Jan 2017 22:37:04 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from [IPv6:2001:7b8:3a7::7049:d69d:d97f:c66f] (unknown
 [IPv6:2001:7b8:3a7:0:7049:d69d:d97f:c66f])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id D76E425530;
 Wed, 11 Jan 2017 23:37:02 +0100 (CET)
Content-Type: multipart/signed;
 boundary="Apple-Mail=_4FED3BA0-1148-4DE5-A65D-4E8CF6CE1323";
 protocol="application/pgp-signature"; micalg=pgp-sha1
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: svn commit: r311929 - head/sys/boot/common
From: Dimitry Andric <dim@FreeBSD.org>
In-Reply-To: <CAGHfRMBGY=SUHLoUB8qLv2pFXNkFDoDdHW2Xqu97xgba6pY0Yg@mail.gmail.com>
Date: Wed, 11 Jan 2017 23:36:55 +0100
Cc: Ian Lepore <ian@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Message-Id: <0ADFDAAC-3858-49B1-BB37-E179D55AF6CE@FreeBSD.org>
References: <201701111847.v0BIl0Mg013954@repo.freebsd.org>
 <CAGHfRMBy7KPP=vLjEpyfRuf_u4S+2mO_W3US9WodMf=ckRJKBQ@mail.gmail.com>
 <1484170956.86335.17.camel@freebsd.org>
 <8EF36240-8CD0-449E-AA9C-EFFB7BF0C111@FreeBSD.org>
 <CAGHfRMBGY=SUHLoUB8qLv2pFXNkFDoDdHW2Xqu97xgba6pY0Yg@mail.gmail.com>
To: Ngie Cooper <yaneurabeya@gmail.com>
X-Mailer: Apple Mail (2.3124)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jan 2017 22:37:04 -0000


--Apple-Mail=_4FED3BA0-1148-4DE5-A65D-4E8CF6CE1323
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On 11 Jan 2017, at 23:32, Ngie Cooper <yaneurabeya@gmail.com> wrote:
>=20
> On Wed, Jan 11, 2017 at 2:10 PM, Dimitry Andric <dim@freebsd.org> =
wrote:
>=20
> ...
>=20
>> The line:
>>=20
>>    extern int errno;
>>=20
>> expanded to:
>>=20
>>    extern int (* __error());
>>=20
>> which is a declaration of an external function pointer called __error
>> (albeit with an empty parameter list).  Since nobody actually refers =
to
>> this symbol in libstand, there are no later complaints.
>>=20
>> Interestingly, reloc_elf.c does not use errno at all, so I have no =
idea
>> why the include was originally added.
>=20
> This is why:
>=20
> 95dd728f5ca86 (iedowse  2004-08-28 23:03:05 +0000 221) #else
> 95dd728f5ca86 (iedowse  2004-08-28 23:03:05 +0000 222)  return =
(EOPNOTSUPP);
> 95dd728f5ca86 (iedowse  2004-08-28 23:03:05 +0000 223) #endif
>=20
> You probably just broke tinderbox on non-x86/-powerpc.

Not very likely, since <stand.h> includes <sys/errno.h>.

-Dimitry


--Apple-Mail=_4FED3BA0-1148-4DE5-A65D-4E8CF6CE1323
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.30

iEYEARECAAYFAlh2s44ACgkQsF6jCi4glqOlvACgz3TmtZNnUB6yjD8oiithWfpX
aBEAoNSklFcZWVQLRQnK5jPYmMTSgfuK
=W3s1
-----END PGP SIGNATURE-----

--Apple-Mail=_4FED3BA0-1148-4DE5-A65D-4E8CF6CE1323--