Date: Mon, 31 Jul 2006 14:49:05 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Pyun YongHyeon <yongari@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/em if_em.c Message-ID: <20060731144841.Y71432@fledge.watson.org> In-Reply-To: <20060731131502.GS96644@FreeBSD.org> References: <200607200357.k6K3vwg2039627@repoman.freebsd.org> <20060731131502.GS96644@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 31 Jul 2006, Gleb Smirnoff wrote: > On Thu, Jul 20, 2006 at 03:57:58AM +0000, Pyun YongHyeon wrote: > P> yongari 2006-07-20 03:57:58 UTC > P> > P> FreeBSD src repository > P> > P> Modified files: > P> sys/dev/em if_em.c > P> Log: > P> Honor IFF_DRV_OACTIVE in em_start_locked(). > > Isn't it better to shift this change to the em_start(), to avoid double > check of IFF_DRV_RUNNING? Or may be just merge em_start_locked() into the > em_start()? Isn't em_start_locked() called from quite a few different places, including the interrupt handler, etc, where the mutex is already held? Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060731144841.Y71432>