Date: Tue, 28 Feb 2017 16:49:50 -0800 From: Scott Long <scottl@netflix.com> To: cem@freebsd.org Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314420 - head/sys/kern Message-ID: <B7F96096-1F33-40DB-9899-627040B32671@netflix.com> In-Reply-To: <CAG6CVpVdWg3XQS-0Vo7dz2NudJCArufNA7Bc7wN=ygK6q_vVvw@mail.gmail.com> References: <201702282127.v1SLRqDH048319@repo.freebsd.org> <CAG6CVpVdWg3XQS-0Vo7dz2NudJCArufNA7Bc7wN=ygK6q_vVvw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Sure, but it doesn=E2=80=99t match the comments in that if-else = construct. Scott > On Feb 28, 2017, at 2:02 PM, Conrad Meyer <cem@FreeBSD.org> wrote: >=20 > On Tue, Feb 28, 2017 at 1:27 PM, Scott Long <scottl@freebsd.org> = wrote: >> Author: scottl >> Date: Tue Feb 28 21:27:51 2017 >> New Revision: 314420 >> URL: https://svnweb.freebsd.org/changeset/base/314420 >>=20 >> Log: >> Provide a comment on why stdio.h needs to be included. >>=20 >> Modified: >> head/sys/kern/subr_prf.c >>=20 >> Modified: head/sys/kern/subr_prf.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/kern/subr_prf.c Tue Feb 28 21:18:45 2017 = (r314419) >> +++ head/sys/kern/subr_prf.c Tue Feb 28 21:27:51 2017 = (r314420) >> @@ -76,6 +76,13 @@ __FBSDID("$FreeBSD$"); >> #include <machine/stdarg.h> >> #else >> #include <stdarg.h> >> +#endif >> + >> +/* >> + * This is needed for sbuf_putbuf() when compiled into userland. = Due to the >> + * shared nature of this file, it's the only place to put it. >=20 > Couldn't it go in the #else clause above? >=20 > Best, > Conrad >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B7F96096-1F33-40DB-9899-627040B32671>