Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 29 Aug 2012 15:21:38 -0700
From:      David O'Brien <obrien@FreeBSD.org>
To:        Pietro Cerutti <gahr@FreeBSD.org>
Cc:        freebsd-ports-bugs@FreeBSD.org
Subject:   Re: ports/171158: [patch] editors/vim -- remove limitation on unthreaded version of Tcl
Message-ID:  <20120829222138.GA11490@dragon.NUXI.org>
In-Reply-To: <201208291020.q7TAKETL048000@freefall.freebsd.org>
References:  <201208291020.q7TAKETL048000@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi Pietro,

>  .if defined(WITH_TCL)
>  USE_TCL=	82+
> -USE_TCL_NO_THREADS=	yes
>  .endif

Pietro,
What version of TCL did you test with?  (I'm guessing 8.5).

The limitation comes from r204122, which re-enabled support for
Tcl versions 8.0, 8.2, 8.3, 8.4, 8.5 (after being disabled by Kris
in r179352).  At the time Vim was version 7.1 PL-175.
We've since removed Tcl 8.0 support from ports.

I'd really rather not have to test the full matrix of all the TCL
versions... I wonder if this isn't what we should commit:

Index: Makefile
===================================================================
--- Makefile	(revision 302880)
+++ Makefile	(working copy)
@@ -90,4 +90,3 @@ MAKE_ARGS+=	CONF_OPT_RUBY="--enable-ruby
 .if defined(WITH_TCL)
-USE_TCL=	82+
-USE_TCL_NO_THREADS=	yes
+USE_TCL=	85+
 .endif


Thoughts?
-- 
-- David



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120829222138.GA11490>