Date: Fri, 25 Jul 2003 16:11:27 -0500 From: "Alan L. Cox" <alc@imimic.com> To: Maxime Henrion <mux@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_contig.c Message-ID: <3F219CFF.ECFF953D@imimic.com> References: <200307252102.h6PL2PFL063697@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Maxime Henrion wrote: > > mux 2003/07/25 14:02:25 PDT > > FreeBSD src repository > > Modified files: > sys/vm vm_contig.c > Log: > Add support for the M_ZERO flag to contigmalloc(). > > Reviewed by: jeff > > Revision Changes Path > 1.21 +5 -1 src/sys/vm/vm_contig.c This has a bug. The page is not mapped at the time you perform bzero(). (In fact, it is not mapped until after the vm_map_wire() occurs.) Thus, you need to use pmap_zero_page() instead. Your tests probably succeeded because of page prezeroing. (With prezeroing, you never exercised the bug.) I'm pretty sure that I sent you an e-mail about this. If not, I apologize. Regards, Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3F219CFF.ECFF953D>