Date: Fri, 14 Feb 2003 15:33:14 +0100
From: Maxime Henrion <mux@freebsd.org>
To: Hiten Pandya <hiten@unixdaemons.com>
Cc: current@FreeBSD.ORG
Subject: Re: KASSERT's for vfs_{get,copy}opt()
Message-ID: <20030214143313.GC60813@elvis.mu.org>
In-Reply-To: <20030214103359.GA73639@unixdaemons.com>
References: <20030214103359.GA73639@unixdaemons.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hiten Pandya wrote: > Hello everyone. This not something major, but I recently experienced > panics in some of my old QNX4 filesystem porting code, and an old 5.0 > kernel with UNIONFS problems. > > The kernel will panic if vfs_get/copyopt() was passed 'opts' as NULL. > It would be good to add KASSERT's to these calls. I have passed this > patch around on IRC, and have not seen any objections. Why the need for a KASSERT() when we will panic() anyway if NULL is passed ? There's no need for manually calling panic() when the code will end doing so, and I specifically did not put KASSERT() there for this reason. Cheers, Maxime To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030214143313.GC60813>