From owner-cvs-all@FreeBSD.ORG  Tue Apr  8 08:36:28 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id ACD7A37B401; Tue,  8 Apr 2003 08:36:28 -0700 (PDT)
Received: from gvr.gvr.org (gvr.gvr.org [212.61.40.17])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2CE8C43FBF; Tue,  8 Apr 2003 08:36:27 -0700 (PDT)
	(envelope-from guido@gvr.org)
Received: by gvr.gvr.org (Postfix, from userid 657)
	id 7889041; Tue,  8 Apr 2003 17:36:25 +0200 (CEST)
Date: Tue, 8 Apr 2003 17:36:25 +0200
From: Guido van Rooij <guido@gvr.org>
To: Maxime Henrion <mux@FreeBSD.org>
Message-ID: <20030408153625.GA78927@gvr.gvr.org>
References: <200304081305.h38D5CGH038749@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200304081305.h38D5CGH038749@repoman.freebsd.org>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Apr 2003 15:36:29 -0000

On Tue, Apr 08, 2003 at 06:05:12AM -0700, Maxime Henrion wrote:
> mux         2003/04/08 06:05:12 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/fxp          if_fxp.c 
>   Log:
>   Fix the hangs people have been seeing.  For some reason, the
>   atomic operation change caused this, so backout it until I
>   can figure out what's wrong with it.

FRom the look of it, it seems you have an error in your patch.
Shouldn't:
atomic_clear_32((u_int32_t *)&last->tx_cb->cb_status,
	    htobe32(bswap16(FXP_CB_COMMAND_S)));

be:

atomic_clear_32((u_int32_t *)&last->tx_cb->cb_command,
	    htobe32(bswap16(FXP_CB_COMMAND_S)));

-Guido