From owner-svn-src-all@FreeBSD.ORG  Thu Nov 29 07:24:00 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id C8AFADC8
 for <svn-src-all@freebsd.org>; Thu, 29 Nov 2012 07:24:00 +0000 (UTC)
 (envelope-from andre@freebsd.org)
Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2])
 by mx1.freebsd.org (Postfix) with ESMTP id 2204A8FC14
 for <svn-src-all@freebsd.org>; Thu, 29 Nov 2012 07:23:59 +0000 (UTC)
Received: (qmail 48575 invoked from network); 29 Nov 2012 08:55:19 -0000
Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2])
 (envelope-sender <andre@freebsd.org>)
 by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP
 for <vijju.singh@gmail.com>; 29 Nov 2012 08:55:19 -0000
Message-ID: <50B70D81.5090000@freebsd.org>
Date: Thu, 29 Nov 2012 08:23:45 +0100
From: Andre Oppermann <andre@freebsd.org>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:16.0) Gecko/20121026 Thunderbird/16.0.2
MIME-Version: 1.0
To: Vijay Singh <vijju.singh@gmail.com>
Subject: Re: svn commit: r243627 - head/sys/kern
References: <201211272004.qARK4qS8047209@svn.freebsd.org>
 <CAGE5yCpxOdsjefe6quR_gjs82pk9a2e_H_WUNUWhUGA3WZPJaw@mail.gmail.com>
 <50B54180.5020608@freebsd.org>
 <alpine.BSF.2.00.1211272246560.37292@fledge.watson.org>
 <50B54492.5040100@freebsd.org>
 <956CE44A-BA0F-4FE4-AA38-F4B90C85ECBA@FreeBSD.org>
 <50B54CE0.6080008@freebsd.org>
 <2A12C740-1D72-4D30-B663-47A37AAC2FF3@FreeBSD.org>
 <50B5C4F1.1020002@freebsd.org>
 <CALCNsJT_my7NRCzOyP3f=soQW4aM1jt+b5=+ABeCpVFFenrVBQ@mail.gmail.com>
In-Reply-To: <CALCNsJT_my7NRCzOyP3f=soQW4aM1jt+b5=+ABeCpVFFenrVBQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, "Robert N. M. Watson" <rwatson@freebsd.org>,
 Peter Wemm <peter@wemm.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Nov 2012 07:24:00 -0000

On 29.11.2012 01:35, Vijay Singh wrote:
>> a sign of poor prior testing and too much trust into the submitter of
>> the patch it wasn't an earth shattering event.  Doesn't distract from
>
> Andre, I am really quite disappointed to read this from you. The patch
> I sent you was fine, and has been well tested here. You modified it
> and made the error. If you wish, I can attach the mail I sent with the
> patch.

Vijay,

Your original patch indeed was correct wrt. testing against the head pointer.

On Nov. 2 I sent you my (wrongly) modified patch for review and testing.
On Nov. 5 you replied that is looks good to you.

There is no doubt that I screwed up about everything else on this patch
but I did send it for review and you didn't catch the mistake I made.

-- 
Andre