Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 18 Dec 2008 12:35:50 GMT
From:      Weongyo Jeong <weongyo@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 154931 for review
Message-ID:  <200812181235.mBICZobT036405@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=154931

Change 154931 by weongyo@weongyo_ws on 2008/12/18 12:34:53

	IMO if the USB framework returns USBD_CANCELLED then we also should
	set USBD_URB_STATUS(urb) as USBD_STATUS_CANCELED not
	USBD_STATUS_SUCCESS.  I've looked lots for NDIS driver; it looks most
	drivers set USBD_STATUS_CANCELED.  In ndiswrapper they try to set
	USBD_STATUS_SUCCESS but it looks it's incorrect.

Affected files ...

.. //depot/projects/ndisusb/sys/compat/ndis/subr_usbd.c#27 edit

Differences ...

==== //depot/projects/ndisusb/sys/compat/ndis/subr_usbd.c#27 (text+ko) ====

@@ -1051,7 +1051,7 @@
 		case USBD_CANCELLED:
 			ip->irp_iostat.isb_info = 0;
 			ip->irp_iostat.isb_status = STATUS_CANCELLED;
-			USBD_URB_STATUS(urb) = USBD_STATUS_SUCCESS;
+			USBD_URB_STATUS(urb) = USBD_STATUS_CANCELED;
 			break;
 		default:
 			ip->irp_iostat.isb_info = 0;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812181235.mBICZobT036405>