Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 5 Dec 2002 17:26:07 +0200
From:      Ruslan Ermilov <ru@FreeBSD.ORG>
To:        FUJISHIMA Satsuki <sf@FreeBSD.ORG>, "Tim J. Robbins" <tjr@FreeBSD.ORG>, gad@FreeBSD.ORG
Cc:        current@FreeBSD.ORG
Subject:   Re: SED regression
Message-ID:  <20021205152607.GG54031@sunbay.com>
In-Reply-To: <867keoseqq.wl@gray.plala.or.jp>
References:  <867keoseqq.wl@gray.plala.or.jp>

next in thread | previous in thread | raw e-mail | index | archive | help

--J/zg8ciPNcraoWb6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 05, 2002 at 11:49:01PM +0900, FUJISHIMA Satsuki wrote:
> Does anyone see this?
> both -CURRENT and -STABLE fail at the same place.
>=20
> note: GNU sed 3.02 from ports passed this test.
>=20
> /usr/src/tools/regression/usr.bin/sed$ make
> Running test G
> PASS: Test G detected no regression. (in /usr/src/tools/regression/usr.bi=
n/sed)
> Running test P
> PASS: Test P detected no regression. (in /usr/src/tools/regression/usr.bi=
n/sed)
> Running test psl
> PASS: Test psl detected no regression. (in /usr/src/tools/regression/usr.=
bin/sed)
> Running test bcb
> PASS: Test bcb detected no regression. (in /usr/src/tools/regression/usr.=
bin/sed)
> Running test y
> --- regress.y.out	Fri Jun 28 01:07:51 2002
> +++ -	Thu Dec  5 23:26:19 2002
> @@ -1 +1 @@
> -fOO
> \ No newline at end of file
> +fOO
> FAIL: Test y failed: regression detected.  See above. (in /usr/src/tools/=
regression/usr.bin/sed)
> *** Error code 1
>=20
> Stop in /usr/src/tools/regression/usr.bin/sed.
>=20
The usr.bin/sed/process.c,v 1.21 change is responsible for the "breakage":

: revision 1.21
: date: 2002/06/22 01:42:26;  author: tjr;  state: Exp;  lines: +10 -11
: Don't store newlines at the end of each line in the hold/pattern spaces,
: instead add the newline when the pattern space is printed. Make the `G' a=
nd
: `H' commands add a newline to the space before the data, remove bogus
: addition of newline from `x' command.
:=20
: PR:		29790, 38195

But I'm pretty confident that what we do now is correct, and it seems to
be in agreement with POSIX.1-2001, which says:

: In default operation, sed cyclically shall append a line of input,
: less its terminating <newline>, into the pattern space.
: ...
: Whenever the pattern space is written to standard output or a named
: file, sed shall immediately follow it with a <newline>.

(This regression test turned into a failure only after a
contrib/diff/util.c,v 1.5 commit.)


Cheers,
--=20
Ruslan Ermilov		Sysadmin and DBA,
ru@sunbay.com		Sunbay Software AG,
ru@FreeBSD.org		FreeBSD committer,
+380.652.512.251	Simferopol, Ukraine

http://www.FreeBSD.org	The Power To Serve
http://www.oracle.com	Enabling The Information Age

--J/zg8ciPNcraoWb6
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)

iD4DBQE973APUkv4P6juNwoRAsm3AJjWtVrIJfxBrs9kDF80TCC9fsidAJ40NTUm
QpxX/+y3YGk2KZXcJloPvg==
=xAhI
-----END PGP SIGNATURE-----

--J/zg8ciPNcraoWb6--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021205152607.GG54031>