Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 May 2017 11:33:44 +0000 (UTC)
From:      =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <royger@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r318631 - head/sys/dev/xen/netfront
Message-ID:  <201705221133.v4MBXieZ069926@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: royger
Date: Mon May 22 11:33:44 2017
New Revision: 318631
URL: https://svnweb.freebsd.org/changeset/base/318631

Log:
  xen/netfront: don't drop the RX lock in xn_rxeof
  
  Since netfront uses different locks for the RX and TX paths there's no need to
  drop the RX lock before calling if_input.
  
  Suggested by:	jhb
  Tested by:	cperciva
  Sponsored by:	Citrix Systems R&D
  MFC with:	r318523

Modified:
  head/sys/dev/xen/netfront/netfront.c

Modified: head/sys/dev/xen/netfront/netfront.c
==============================================================================
--- head/sys/dev/xen/netfront/netfront.c	Mon May 22 10:28:17 2017	(r318630)
+++ head/sys/dev/xen/netfront/netfront.c	Mon May 22 11:33:44 2017	(r318631)
@@ -1224,7 +1224,6 @@ xn_rxeof(struct netfront_rxq *rxq)
 		RING_FINAL_CHECK_FOR_RESPONSES(&rxq->ring, work_to_do);
 	} while (work_to_do);
 
-	XN_RX_UNLOCK(rxq);
 	mbufq_drain(&mbufq_errq);
 	/*
 	 * Process all the mbufs after the remapping is complete.
@@ -1253,7 +1252,6 @@ xn_rxeof(struct netfront_rxq *rxq)
 	 */
 	tcp_lro_flush_all(lro);
 #endif
-	XN_RX_LOCK(rxq);
 }
 
 static void



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201705221133.v4MBXieZ069926>