Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 26 Jan 2019 09:45:18 +0100
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Yuri Victorovich <yuri@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r491209 - head/deskutils/recoll
Message-ID:  <20190126084518.obgbco4zg753tub7@atuin.in.mat.cc>
In-Reply-To: <201901252308.x0PN8Odn087108@repo.freebsd.org>
References:  <201901252308.x0PN8Odn087108@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--akuwdc6v67kocmda
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 25, 2019 at 11:08:24PM +0000, Yuri Victorovich wrote:
> Author: yuri
> Date: Fri Jan 25 23:08:24 2019
> New Revision: 491209
> URL: https://svnweb.freebsd.org/changeset/ports/491209
>=20
> Log:
>   deskutils/recoll: Update 1.23.7 -> 1.24.3
>  =20
>   * New dependency of QT5. Remove all references to QT4
>   * Add gnome to USES
>   * Shebang file desktop/hotrecoll.py moved to filters/hotrecoll.py
>   * Portlint suggestions:
>       USE_LDCONFIG=3Dyes
>       USE_GL+=3Dgl when QT5 options is enabled

So, let me remind you.  A commit message is about *WHY* you are doing
the things you are doing.  NEVER about WHAT you are doing.  Anyone can
read a diff, see that you removed Qt4 in favor of Qt5, added stuff to
USES, changed a line here and ther, so documenting this does not help
anyone.

What you need to document is WHY you are doing the changes, so that
someone reading the diff understands the reason behind the changes.

Here, the commit message may have looked like:

  Update to 1.24.3

  Switch from Qt4 to Qt5 and removed deprecation.
  Fix some QA warnings.

And that's it.  All other changes are related to updating the port or
cleaning things up a bit.

> @@ -70,9 +70,9 @@ X11MON_CONFIGURE_WITH=3D	fam
>  X11MON_BROKEN=3D		does not build: index/rclmonrcv.cpp:(.text+0x1f13): un=
defined reference to `FAMOpen2'
> =20
>  .include <bsd.port.options.mk>
> -.if ${PORT_OPTIONS:MQT4}
> -DEPRECATED=3D		Qt4 has been EOL since december 2015
> -EXPIRATION_DATE=3D	2019-03-15
> +
> +.if ${PORT_OPTIONS:MQT5}
> +USE_GL+=3Dgl
>  .endif

QT5_USE=3D   gl+=3Dgl

--=20
Mathieu Arnold

--akuwdc6v67kocmda
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlxMHh5fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB
QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD
zkinhhAAg87J1zdH5ANzjl93BiJaGVnlbqujAE9a8pYa3TmkgqjBlc77KrmyrYp4
XCEhysqMDN7KO5a3YIyvz/6RnkmXW2G8Ki9v10iOwWR0oMK6C9BFsMkeQQvc9ch2
W9YEVmoZd1qEhbC1YegoQcUykEpXTcbtQ3Fa6OaHLjWK5a1FgT5Hj1TE4RKRM2lY
ei9Oq4FZZf6LHZBlA1o4UInqMGi5gTBrGzZ/ZIWxFfYOaz9Zl8WJu10WR9cQd3/F
tZcJkXXgwzkqzmPLlqeQyKUsGNt3kDoHwE1DN+K6tX8a3rHTYnb3BqqGf9zPBs0Q
C00T2O+4JompYvBZbn33IXXDALPrRXDi4PRF9LKWzoIikDz/5Hl1u6RixgB/cfg0
mfogGSA5lAVjDeCi46paoK5is4rSASbWqwmCNRL5fVfb6BaMLnVzyvMUgvj/jVnJ
VxtI8I4gAdoH5Xjb4y9zzHU7mHxiLKAR6m8ry8rTOXFriAlLDct8hqRjK3X11Trx
5bFbsONIICqaU1uFRXIm3tNXmAOSw4UjTFMLmqb+UktNo5kED4z1DZbo2ip0wYU6
4pD6Oo3v7/g7QrzrdIAApmIgFh/4O/GrYcGOmJ7WUHPrxlB56x/1rrPZJpwcXmOO
+35kGvqxyCcKo+jP/mEEWKacdbrZRm7W6q7oc6THk9CP3zvEcZY=
=y4AH
-----END PGP SIGNATURE-----

--akuwdc6v67kocmda--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190126084518.obgbco4zg753tub7>