Date: Thu, 24 Nov 2016 20:39:37 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: John Baldwin <jhb@freebsd.org> Cc: Marcelo Araujo <araujobsdport@gmail.com>, araujo@freebsd.org, src-committers@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r309109 - head/lib/libutil Message-ID: <86vavc3bwm.fsf@desk.des.no> In-Reply-To: <2094160.1ufjjsmd6m@ralph.baldwin.cx> (John Baldwin's message of "Thu, 24 Nov 2016 11:11:21 -0800") References: <201611241450.uAOEoLA5079215@repo.freebsd.org> <CAOfEmZgexP65RKz1=WxcFBWTYGYbnSHWMzknkGAeFN=DwjBL8A@mail.gmail.com> <861sy0n8re.fsf@desk.des.no> <2094160.1ufjjsmd6m@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin <jhb@freebsd.org> writes: > Of course, there's only one person who has touched flopen [...] > Perhaps you were just warning yourself? :) Precisely. If memory serves, I wrote that comment after receiving a patch from someone who made the same mistake that I had already made and reverted *twice*. It's the logical, sane thing to do: replace a BSD primitive with the equivalent POSIX primitive, except the latter has subtly different semantics and works in some of flopen(3)'s typical use cases, but not all, and crucially, not in the pidfile(3) case. I just remembered that I wrote a unit test for flopen(3). So maybe the comment is redundant... if you assume that people build and run the tests, and I'm willing to bet that they don't, because our test framework is not very developer-friendly. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86vavc3bwm.fsf>