Date: Sun, 23 Oct 2011 15:08:54 -0500 From: Nathan Whitehorn <nwhitehorn@freebsd.org> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: freebsd-bugs@freebsd.org, freebsd-sysinstall@freebsd.org Subject: Re: bin/161926: bsdinstall(8): disk layout trouble Message-ID: <4EA47456.7090008@freebsd.org> In-Reply-To: <8392.1319393700@critter.freebsd.dk> References: <8392.1319393700@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/23/11 13:15, Poul-Henning Kamp wrote: > In message<4EA43608.2070703@freebsd.org>, Nathan Whitehorn writes: > >>> Keymap Selection -> No >>> "non-default key mapping" ??? >>> What kind of question is that ? >> Can you suggest an alternate wording for this? This was a request from >> PR bin/160913. > "Do you want US/English keyboard ?" OK, the wording can be changed. >>> Ohh, there are *no* "back" buttons *anywhere* ? >> jilles@ was going to add these at one point, so I dropped the issue. I >> don't know what happened with that -- perhaps it is worth revisiting. > I have noted your candidacy for the "Understatement of the month" award. There's not actually too much need for them, and so they never seemed pressing. Pressing control-C/choosing "cancel"/etc. will either skip steps that can be returned to later (post-extraction) or return to the beginning of the installation, which is where you already were, pre-extraction. It seemed better to have a back-button-free version than buggy back buttons like in sysinstall, anyway. >>> Partition >>> ada0 Modify >>> "Invalid argument. arg0 'ada0' >>> MBR >> Can you provide some more detail on how you got here? This is a geom >> bug, and it would be nice to track it down. > Try dd if=/dev/zero of=/dev/$whatever bs=128 on your target disk before > installation. Can't reproduce that one at all. What steps did you take after that? Just pressing create and choosing MBR? Or were there more? >>> Active partition is the last one created ? >>> There is no place I can see it ? >>> There is no place I can change it ? >> Active partition is the last bootable (e.g. freebsd) partition you >> created, yes. > That is *totally* bogus, at the very least, make it the first one. The UI problem is actually hard, and the correct solution without a UI solution is non-obvious. The usual use case, where only one MBR partition of type freebsd is added, works perfectly well. I'll try to find a reasonable solution to this, but have very little time at the moment -- patches would be much appreciated. >> 1. Move "Shell" out of that screen, into the "Installation finished. >> What would you like to do now?" screen, when the install is actually >> complete. This is the easiest solution by far, and maybe the best. > That works for me. I'll fix it this way, then. >>> I tried once before with a disk which contained a Ubuntu installation, >>> there I ended up with partition 2 having size of "-37GB" on a 40GB >>> drive. >> Again, can you provide more details on how you got there? You seem to >> have found a *lot* of bugs in gpart. > Sorry, that one is not reproducible now. You can try to install an > Ubuntu on a 40GB disk, but... > >> Back buttons are kind of hard in shell scripts, but I'm on it :P > You're doing this as shell-scripts ? > No -- that way would lie madness. There are several components to the installer which are separate executables, and all but the simplest are C programs. The main installation process is done by invoking them in sequence, as a short shell script. This substantially improves the modularity of the installer, and makes scripting it much easier. It also makes back buttons very hard to implement, since they break this encapsulation -- not severely, but enough to cause problems. As I said, I'll take another look at doing them, but it's a nontrivial thing. -Nathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EA47456.7090008>